Internalize sqlinference module into quary-core #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency Move the sqruff-sqlinference crate's functionality (test types, test inference, column extraction, aggregate function analysis) directly into quary-core as the `sqlinference` module. This consolidates lineage and test inference logic that is quary-specific into the quary codebase itself, removing the external dependency on sqruff-sqlinference while retaining sqruff-lib-core and sqruff-lib-dialects for SQL parsing. - Created `rust/core/src/sqlinference/` module with: mod.rs, test.rs, infer_tests.rs, inference.rs, columns.rs, aggregate_functions.rs - Updated all imports across quary-core, wasm-binding to use the internal module - Removed sqlinference dependency from workspace and all crate Cargo.toml files (workspace root, core, cli, wasm-binding, quary-databases) - All 180 unit tests + 4 doctests + 22 wasm-binding tests pass https://claude.ai/code/session_01PrksUCESEqgJJL5Bu1d2uH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR internalizes the
sqruff-sqlinferenceexternal crate as a newsqlinferencemodule withinquary-core. All references to the external crate have been updated to use the internal module instead.Key Changes
sqruff-sqlinference(v0.34.1) from workspace dependencies and all crate manifests (cli, core, databases, wasm-binding)rust/core/src/sqlinference/module with the following submodules:mod.rs- Module entry point with SQL parsing utilitiestest.rs- Test type definitions (NotNull, Unique, Relationship, AcceptedValues, comparison tests)aggregate_functions.rs- Aggregate function behavior and test inferrability logiccolumns.rs- Column extraction from SQL SELECT statementsinfer_tests.rs- Test inference logic from SQL queriesinference.rs- Test runner action determination (Run/Skip with reasons)sqlinference::tocrate::sqlinference::across:rust/core/src/lib.rs- Added module declarationrust/core/src/description_table.rsrust/core/src/project.rsrust/core/src/rpc_proto_defined_functions.rsrust/core/src/sql_inference_translator.rsrust/core/src/tests.rsrust/wasm-binding/src/rpc_proto_defined_functions.rsImplementation Details
https://claude.ai/code/session_01PrksUCESEqgJJL5Bu1d2uH