feat(ui): add indicator-shape prop to QTabs#17978
Open
stefanvanherwijnen wants to merge 1 commit intoquasarframework:devfrom
Open
feat(ui): add indicator-shape prop to QTabs#17978stefanvanherwijnen wants to merge 1 commit intoquasarframework:devfrom
stefanvanherwijnen wants to merge 1 commit intoquasarframework:devfrom
Conversation
Build ResultsJSON API📜 Changes detected: diff --git a/./current-build/api/QTabs.json b/./pr-build/api/QTabs.json
index e4ca148..9f63c8b 100644
--- a/./current-build/api/QTabs.json
+++ b/./pr-build/api/QTabs.json
@@ -90,6 +90,17 @@
],
"category": "style"
},
+ "indicator-shape": {
+ "type": "String",
+ "desc": "The shape of the active indicator.",
+ "default": "'line'",
+ "examples": [
+ "'line'",
+ "'pill'"
+ ],
+ "category": "style",
+ "required": false
+ },
"content-class": {
"type": "String",
"desc": "Class definitions to be attributed to the content wrapper",Types📜 Changes detected: diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index 06232b6..29fffaf 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -14679,6 +14679,11 @@ export interface QTabsProps {
* The color to be attributed to the indicator (the underline) of the active tab
*/
indicatorColor?: NamedColor | undefined;
+ /**
+ * The shape of the active indicator.
+ * Default value: 'line'
+ */
+ indicatorShape?: string | undefined;
/**
* Class definitions to be attributed to the content wrapper
*/ |
UI Tests Results 1 files 98 suites 38s ⏱️ Results for commit 1497936. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Material Design 3 introduces a navigation rail, which is similar to (Q)Tabs but the active indicator is different (pill shape vs line). This PR adds a
indicator-shapeprop to QTabs which makes it possible to use the pill shape active indicator and use QTabs for a navigation rail.