feat: add empty slice declaration check

[demoManito]

https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices

[demoManito]

@quasilyte PTAL

[quasilyte]

I think the issue is that nil slice and empty slice are different things and some APIs may require one or another.
CC @cristaloleg

[demoManito]

I think the issue is that nil slice and empty slice are different things and some APIs may require one or another. CC @cristaloleg

Yes, but I need to detect some empty slices that are not necessary and if not, nolint skips

[demoManito]

golang/go/wiki/CodeReviewComments#declaring-empty-slices

golang wiki

In most cases, empty slices, simply stating that a nil slice is sufficient

[cristaloleg]

Yes, but I need to detect some empty slices that are not necessary and if not, nolint skips

Sounds like a too opinionated. I understand you intention but this is not 1:1 replacement.

However, make([]T, 0, 0) doesn't make sense and can be []T{}.

[demoManito]

Yes, but I need to detect some empty slices that are not necessary and if not, nolint skips

Sounds like a too opinionated. I understand you intention but this is not 1:1 replacement.

However, make([]T, 0, 0) doesn't make sense and can be []T{}.

etcd-io/etcd#14479

Just like in this PR, most empty slices are meaningless, either defined as var a []T, or need to be assigned cap.

I think these situations need to be reported when needed.

@cristaloleg

[demoManito]

[cristaloleg]

most empty slices are meaningless

I agree but blindly replacing it sounds wrong to me, see https://go.dev/play/p/tVN7c2t8kMc

To clarify again: I'm not saying "this a wrong", I'm saying "this check is not for everyone".

Consider to use gocritic (1) or golangci-lint (2) where you can specify this rule

1. https://github.com/go-critic/go-critic/blob/master/.golangci.yml#L45
2. https://golangci-lint.run/usage/linters/#gocritic (ruleguard. rules)

[demoManito]

hello @cristaloleg , go-critic/go-critic#1337 Do you mean to add it here?

[cristaloleg]

Nah, I meant to add it as a personal ruleguard rule.