ncm-spma: support for ssl client settings for yumng and dnf backend.#1852
Merged
jrha merged 2 commits intoquattor:mainfrom Mar 13, 2026
Merged
ncm-spma: support for ssl client settings for yumng and dnf backend.#1852jrha merged 2 commits intoquattor:mainfrom
jrha merged 2 commits intoquattor:mainfrom
Conversation
Add the code for ssl client settings for yumng and dnf backend.
aka7
force-pushed
the
ssl_cert_support
branch
from
c66a18e to
dbe0ac9
Compare
Contributor
|
Would it be possible to have a unit test addition for these settings? |
aka7
force-pushed
the
ssl_cert_support
branch
from
ba27b32 to
97fdf33
Compare
ned21
reviewed
Feb 12, 2026
aka7
force-pushed
the
ssl_cert_support
branch
from
97fdf33 to
d8eec26
Compare
Contributor
|
LGTM but will let someone else approve. |
jrha
reviewed
Mar 4, 2026
adding missing tests for dnf backend. plus yumng ssl config tests
jrha
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the code for ssl client settings for yumng and dnf backend.
schema exists but no code to add it.
Why the change is necessary.
Although the schema exists for protocols settings to add verify cacert clientkey clientcert, etc, but adding it has no effect on the config generation for that repo. at least on two backends we use, yumng and dnf backend.
What backwards incompatibility it may introduce.
None.