Verify SC files automatically

.github/workflows/contract-verify.yml

@@ -0,0 +1,37 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: ContractVerify
+
+on:
+  push:
+    branches: [ "main", "develop", "feature/2025-08-13-contract-verify" ]
+    paths:
+      - 'src/contracts/*.h'
+      - '.github/workflows/contract-verify.yml'
+  pull_request:
+    branches: [ "main", "develop", "feature/2025-08-13-contract-verify" ]
+    paths:
+      - 'src/contracts/*.h'
+      - '.github/workflows/contract-verify.yml'
+
+jobs:
+  contract_verify_job:
+    runs-on: ubuntu-latest
+    name: Verify smart contract files
+    steps:
+      # Checkout repo to use files of the repo as input for container action
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Find all contract files to verify
+        id: filepaths
+        run: |
+          files=$(find src/contracts/ -maxdepth 1 -type f -name "*.h" ! -name "*TestExample*" ! -name "*math_lib*" ! -name "*qpi*" -printf "%p\n" | paste -sd, -)
+          echo "contract-filepaths=$files" >> "$GITHUB_OUTPUT"
+      - name: Contract verify action step
+        id: verify
+        uses: Franziska-Mueller/qubic-contract-verify@v0.3.0-beta
+        with:
+          filepaths: '${{ steps.filepaths.outputs.contract-filepaths }}'

doc/contracts.md

@@ -93,10 +93,10 @@ In order to develop a contract, follow these steps:
 
 Each contract must be validated with the following steps:
 1. The contract is verified with a special software tool, ensuring that it complies with the formal requirements mentioned above, such as no use of forbidden C++ features.
-   (Currently, this tool has not been implemented yet. Thus, this check needs to be done during the review in point 3.)
-2. The features of the contract have to be extensively tested with automated tests implemented within the Qubic Core's GoogleTest framework.
-3. The contract and testing code must be reviewed by at least one of the Qubic Core devs, ensuring it meets high quality standards.
-4. Before integrating the contract in the official Qubic Core release, the features of the contract must be tested in a test network with multiple nodes, showing that the contract works well in practice and that the nodes run stable with the contract.
+   The tool is available in [this repository](https://github.com/Franziska-Mueller/qubic-contract-verify). You can either built it from source or use the provided GitHub action to run it on your contract header file.
+3. The features of the contract have to be extensively tested with automated tests implemented within the Qubic Core's GoogleTest framework.
+4. The contract and testing code must be reviewed by at least one of the Qubic Core devs, ensuring it meets high quality standards.
+5. Before integrating the contract in the official Qubic Core release, the features of the contract must be tested in a test network with multiple nodes, showing that the contract works well in practice and that the nodes run stable with the contract.
 
 After going through this validation process, a contract can be integrated in official releases of the Qubic Core code.
 
@@ -627,3 +627,4 @@ The file `proposal.cpp` has a lot of examples showing how to use both functions.
 For example, `getProposalIndices()` shows how to call a contract function requiring input and providing output with `runContractFunction()`.
 An example use case of `makeContractTransaction()` can be found in `gqmpropSetProposal()`.
 The function `castVote()` is a more complex example combining both, calling a contract function and invoking a contract procedure.
+

src/contracts/ComputorControlledFund.h

@@ -143,7 +143,9 @@ struct CCF : public ContractBase
 	struct GetProposal_output
 	{
 		bit okay;
-		uint8 _padding0[7];
+		Array<uint8, 4> _padding0;
+		Array<uint8, 2> _padding1;
+		Array<uint8, 1> _padding2;
 		id proposerPubicKey;
 		ProposalDataT proposal;
 	};
@@ -285,7 +287,7 @@ struct CCF : public ContractBase
 					continue;
 
 				// Option for transfer has been accepted?
-				if (locals.results.optionVoteCount.get(1) > QUORUM / 2)
+				if (locals.results.optionVoteCount.get(1) > div<uint32>(QUORUM, 2U))
 				{
 					// Prepare log entry and do transfer
 					locals.transfer.destination = locals.proposal.transfer.destination;

src/contracts/GeneralQuorumProposal.h

@@ -279,7 +279,9 @@ struct GQMPROP : public ContractBase
 	struct GetProposal_output
 	{
 		bit okay;
-		uint8 _padding0[7];
+		Array<uint8, 4> _padding0;
+		Array<uint8, 2> _padding1;
+		Array<uint8, 1> _padding2;
 		id proposerPubicKey;
 		ProposalDataT proposal;
 	};
@@ -410,7 +412,7 @@ struct GQMPROP : public ContractBase
 							}
 
 							// Option for changing status quo has been accepted? (option 0 is "no change")
-							if (locals.mostVotedOptionIndex > 0 && locals.mostVotedOptionVotes > QUORUM / 2)
+							if (locals.mostVotedOptionIndex > 0 && locals.mostVotedOptionVotes > div<uint32>(QUORUM, 2U))
 							{
 								// Set in revenueDonation table (cannot be done in END_EPOCH, because this may overwrite entries that
 								// are still needed unchanged for this epoch for the revenue donation which is run after END_EPOCH)

src/contracts/MsVault.h

@@ -804,6 +804,7 @@ struct MSVAULT : public ContractBase
     // [TODO]: Uncomment this to enable live fee update
     PUBLIC_PROCEDURE_WITH_LOCALS(voteFeeChange)
     {
+        return;
     //    locals.ish_in.candidate = qpi.invocator();
     //    isShareHolder(qpi, state, locals.ish_in, locals.ish_out, locals.ish_locals);
     //    if (!locals.ish_out.result)