Automatic zero-padding for undersized contract state files#807
Open
fnordspace wants to merge 1 commit intoqubic:developfrom
Open
Automatic zero-padding for undersized contract state files#807fnordspace wants to merge 1 commit intoqubic:developfrom
fnordspace wants to merge 1 commit intoqubic:developfrom
Conversation
| // forceLoadFromFile: when loading node states from file, we want to make sure it load from file and ignore constructionEpoch == system.epoch case | ||
| static bool loadContractStateFiles(CHAR16* directory, bool forceLoadFromFile) | ||
| { | ||
| // Contracts whose state struct grew this epoch. Update this list each epoch as needed. |
Collaborator
There was a problem hiding this comment.
could we move this to somewhere where it's easier to find? e.g. contract_def.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a contract's state struct grows between epochs, the on-disk state file from the previous epoch is smaller than the new expected size, causing the node to fail loading.
This adds a padding mechanism that detects undersized contract files and zero-pads them: it zeros the entire buffer, then loads the smaller file into the front. New fields are automatically zero-initialized.
Padding is only applied to contracts explicitly listed in the paddableContracts whitelist to prevent masking file corruption.