Closed
Conversation
…d update vulnerable dependencies
qubicmio
reviewed
Jan 23, 2025
qubicmio
reviewed
Jan 23, 2025
Member
|
lgtm (except the retry code duplication - not sure if there is a way to make that nicer) |
0xluk
reviewed
Jan 24, 2025
Collaborator
@qubicmio I addressed that in the review |
0xluk
reviewed
Jan 28, 2025
foundation/rpc_server/rpc_server.go
Outdated
|
|
||
| func NewServer(listenAddrGRPC, listenAddrHTTP string, logger *log.Logger, | ||
| qPool *qubic.Pool, maxTickFetchUrl string, readRetryCount int) *Server { | ||
| func NewServer(listenAddrGRPC, listenAddrHTTP string, logger *log.Logger, qPool *qubic.Pool, maxTickFetchUrl string, readRetryCount int) *Server { |
Collaborator
There was a problem hiding this comment.
readRetryCount is not a proper variable time as from a config point of view it's not a count but a readMaxRetries
0xluk
reviewed
Jan 28, 2025
foundation/rpc_server/rpc_server.go
Outdated
| return 0, errors.Wrap(err, "performing request") | ||
| } | ||
| defer res.Body.Close() | ||
| for attempt := 0; attempt <= maxRetries; attempt++ { |
Collaborator
There was a problem hiding this comment.
shouldn't this be attempt < maxRetries
0xluk
reviewed
Jan 28, 2025
app/grpc_server/main.go
Outdated
| HttpHost string `conf:"default:0.0.0.0:8000"` | ||
| GrpcHost string `conf:"default:0.0.0.0:8001"` | ||
| MaxTickFetchUrl string `conf:"default:http://127.0.0.1:8080/max-tick"` | ||
| ReadRetryCount int `conf:"default:5"` |
Collaborator
There was a problem hiding this comment.
same here, it's not a count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry mechanism for all endpoints that request data from nodes and update vulnerable dependencies.