chore: move OpenAPI adjustments from Makefile to CI workflow#50
Open
chore: move OpenAPI adjustments from Makefile to CI workflow#50
Conversation
Move yq post-processing (x-scalar-ignore on QubicLiveService) from the Makefile to the GitHub Actions workflow. The Makefile now generates raw protoc output, and adjustments are applied on-the-fly before dispatching the base64-encoded spec to consumer repos (integration, docs).
Contributor
Author
|
Related PRs (need to be merged before): |
sallymoc
force-pushed
the
chore/openapi-ci-adjustments
branch
from
02f1016 to
e9bd05f
Compare
Fails the PR if the committed OpenAPI YAML doesn't match what protoc would generate from the current proto files.
sallymoc
force-pushed
the
chore/openapi-ci-adjustments
branch
from
e9bd05f to
1aff544
Compare
qubicmio
reviewed
Mar 5, 2026
| - run: go test ./... No newline at end of file | ||
| - run: go test ./... | ||
|
|
||
| check-openapi: |
Member
There was a problem hiding this comment.
Not sure about this one because I don't know, if different plugin versions might generate slightly different output. (we can change this later, if we are not sure)
Member
|
If it works (one question) then lgtm. |
qubicmio
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move yq post-processing (x-scalar-ignore on QubicLiveService) from the Makefile to the GitHub Actions workflow. The Makefile now generates raw protoc output, and adjustments are applied on-the-fly before dispatching the base64-encoded spec to consumer repos (integration, docs).