feat: Add a bridge for getPlacement method #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbalawajdermq
approved these changes
Sep 30, 2020
dzmiquido
force-pushed
the
feature/placements-bridge
branch
from
d850d72 to
e39b395
Compare
dzmiquido
force-pushed
the
feature/placements-bridge
branch
3 times, most recently
from
3d2e0c4 to
8734148
Compare
dzmiquido
force-pushed
the
feature/placements-bridge
branch
from
8734148 to
d2a7677
Compare
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
android/src/main/java/com/qubit/reactnative/sdk/QubitSDKModule.java
Outdated
Show resolved
Hide resolved
ljazgar
reviewed
Oct 23, 2020
ljazgar
suggested changes
Oct 23, 2020
Contributor
ljazgar
left a comment
ljazgar
left a comment
There was a problem hiding this comment.
There is no consistency in data structures passed through layers of the bridge.
Missing documentation and examples of placement callbacks.
Correct working of placement callbacks is doubtful.
jahudzik
force-pushed
the
feature/placements-bridge
branch
2 times, most recently
from
d5f5a81 to
0e64485
Compare
jahudzik
force-pushed
the
feature/placements-bridge
branch
from
0e64485 to
810d5d3
Compare
…instead of object.
ljazgar
reviewed
Nov 5, 2020
ljazgar
reviewed
Nov 5, 2020
ljazgar
reviewed
Nov 9, 2020
ljazgar
reviewed
Nov 9, 2020
ljazgar
reviewed
Nov 9, 2020
android/src/main/java/com/qubit/reactnative/sdk/QubitSDKModule.java
Outdated
Show resolved
Hide resolved
ljazgar
reviewed
Nov 9, 2020
android/src/main/java/com/qubit/reactnative/sdk/QubitSDKModule.java
Outdated
Show resolved
Hide resolved
…returned from getPlacement() function
jahudzik
force-pushed
the
feature/placements-bridge
branch
from
10b9cb6 to
621e71f
Compare
ljazgar
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.