Open
Conversation
Updated plugin to fulfill the best practices
sandeepV2
reviewed
Sep 30, 2019
| <option name="Password" default="true" value="api-token" /> | ||
| </authentication-options> | ||
| <db-name-prompt value="Catalog :" /> | ||
| <has-databases value="true" /> |
There was a problem hiding this comment.
@saugatt should we not have has-databases enabled in dialogue box?
sandeepV2
reviewed
Sep 30, 2019
| <has-schemas value="true" /> | ||
| <server-prompt value="End Point;Bucket Region : " default="https://api.qubole.com;us-east-1"/> | ||
| <service-prompt value="API Token : " /> | ||
| <show-uncommitted-data-checkbox value="true" /> |
There was a problem hiding this comment.
@saugatt We use show-uncommitted-data-checkbox to enable streaming. I see it is removed. Do we have any specific field to achieve the same?
cc : @vijaymann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove attribute service from connectionResolver.tdr
Change the API token to be password field which is secure.
API Token replaced by password field using PasswordOnly authentication
Add authentication as a required attribute in connectionResolver.tdr
Removed comments from conenctionBuilder.js
Update manifest.xml to use string from resource-en_US.xml
Remove from connection-dialog.tcd