-
Notifications
You must be signed in to change notification settings - Fork 40
Re-export pack, unpack and Text from Data.Text #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,10 @@ library | |
| , Prettyprinter.Render.Util.SimpleDocTree | ||
| , Prettyprinter.Render.Util.StackMachine | ||
| , Prettyprinter.Util | ||
| , Prettyprinter.Util.Compat.Text | ||
| , Prettyprinter.Util.Compat.Text.IO | ||
| , Prettyprinter.Util.Compat.Text.Lazy | ||
| , Prettyprinter.Util.Compat.Text.Lazy.Builder | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These will show up on Hackage, cluttering the package overview quite a bit – half of the whole package is already compatibility stuff. I don’t think there’s a way around this, or is there? Optparse-Applicative is a very popular lib, so allowing Prettyprinter there would be a good thing. But I’m not a fan of cluttering prettyprinter’s public API just so some other package can retain eternal backwards compatibility – why can’t they depend on Text after all? Feels like a pretty strange design decision in anything later than 2010.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps one option is to move these to a separate package altogether? |
||
|
|
||
| , Prettyprinter.Symbols.Unicode | ||
| , Prettyprinter.Symbols.Ascii | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,5 @@ type Text = T.Text | |
| length = T.length | ||
| lines = T.lines | ||
| toStrict = id | ||
| pack = T.pack | ||
| unpack = T.unpack | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| -- | This module is for use by packages that need to be able to use the prettyprinter package | ||
| -- without incurring a dependency on the text package. | ||
| -- | ||
| -- Legitimate examples of packages that must have text as an optional dependency include text (and | ||
| -- bytestring). | ||
| module Prettyprinter.Util.Compat.Text | ||
sjakobi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ( module Data.Text | ||
| ) where | ||
|
|
||
| import Data.Text (Text, cons, dropWhileEnd, head, intercalate, length, lines, map, null, pack, replicate, | ||
| singleton, snoc, stripEnd, unlines, unpack, words, uncons, splitOn) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- | This module is for use by packages that need to be able to use the prettyprinter package | ||
| -- without incurring a dependency on the text package. | ||
| -- | ||
| -- Legitimate examples of packages that must have text as an optional dependency include text (and | ||
| -- bytestring). | ||
| module Prettyprinter.Util.Compat.Text.IO | ||
| ( module Data.Text.IO | ||
| ) where | ||
|
|
||
| import Data.Text.IO (hPutStr, putStrLn) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- | This module is for use by packages that need to be able to use the prettyprinter package | ||
| -- without incurring a dependency on the text package. | ||
| -- | ||
| -- Legitimate examples of packages that must have text as an optional dependency include text (and | ||
| -- bytestring). | ||
| module Prettyprinter.Util.Compat.Text.Lazy | ||
| ( module Data.Text.Lazy | ||
| ) where | ||
|
|
||
| import Data.Text.Lazy (Text, length, lines, toStrict, pack, unpack) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- | This module is for use by packages that need to be able to use the prettyprinter package | ||
| -- without incurring a dependency on the text package. | ||
| -- | ||
| -- Legitimate examples of packages that must have text as an optional dependency include text (and | ||
| -- bytestring). | ||
| module Prettyprinter.Util.Compat.Text.Lazy.Builder | ||
| ( module Data.Text.Lazy.Builder | ||
| ) where | ||
|
|
||
| import Data.Text.Lazy.Builder (Builder (), fromText, singleton, toLazyText) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change still necessary? I don’t see a change that would require those exts in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed
FlexibleInstancesandTypeSynonymInstances. Hopefully it still works. Please approve workflows.