Skip to content

Fix wrong unit-by-label indexing in Qudt #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fkleedorfer merged 1 commit into from
Oct 9, 2025
Merged

Fix wrong unit-by-label indexing in Qudt #124

fkleedorfer merged 1 commit into from
Oct 9, 2025

Conversation

@fkleedorfer
Copy link
Contributor

@fkleedorfer fkleedorfer commented Oct 9, 2025 •
edited
Loading

  • QUDT now uses the correct trie prefix for labels when indexing units
  • Adds a unit test that activated the bug prior to fixing it - the problem was detected when trying to parse g/mole to unit:GM-PER-MOL

@fkleedorfer
Fix wrong unit by label indexin in Qudt
ebd4d2f 
- QUDT now uses the correct trie prefix for labels when indexing units
- Adds a unit test that activated the bug prior to fixing it
@fkleedorfer fkleedorfer merged commit 3c592cc into main Oct 9, 2025
1 check passed
@fkleedorfer fkleedorfer deleted the fix-unit-parsing-bug branch October 9, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fkleedorfer