Open
Conversation
- Add other paramether to `setup_arduino_libraries` for includes: `INCLUDE_PATHS` - Add other paramether to `setup_arduino_library` for includes: `INCLUDE_PATHS` - Removed manual `-I` as manual `COMPILE_FLAGS` with `set_target_properties` in setup_arduino_library` - Add the more CMake semantic `target_include_directories` in `setup_arduino_library`
- Add other parameter to `get_arduino_flags` for get the include paths as a list: INCLUDE_PATHS_VAR - Usage on `GENERATE_ARDUINO_LIBRARY`, `setup_arduino_core`, `setup_arduino_library` and `setup_arduino_target` functions
- Removed `set(${VAR_NAME}_INCLUDES ${LIB_INCLUDES} PARENT_SCOPE)` from `setup_arduino_library` because it is automatically now,
the `target_include_directories` on this function is in `PUBLIC` scope. Read more on:
https://cmake.org/cmake/help/v3.0/command/target_include_directories.html
- Removed `set(${VAR_NAME}_INCLUDES ${LIB_INCLUDES} PARENT_SCOPE)` from `setup_arduino_libraries` cuzy the same... previous.
- Some fix after test.
working on issue queezythegreat#170. do not close this yet
- Add matching macro for mcu, the compiler make this by default, but we need notice the IDE about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainly using include_directories