Skip to content

Commit d847d2f

Browse files
committed
fix: fix more code smell
1 parent 45b7b46 commit d847d2f

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

src/renderer/App.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,14 +127,14 @@ body.dark {
127127

128128
html,
129129
body {
130-
font-family: 'OpenSans';
130+
font-family: 'OpenSans', sans-serif;
131131
font-size: 13px;
132132
padding: 0;
133133
margin: 0;
134134
}
135135

136136
.mono {
137-
font-family: 'CascadiaCode';
137+
font-family: 'CascadiaCode', sans-serif;
138138
}
139139

140140
.scroll::-webkit-scrollbar {

src/renderer/components/Layout/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ export default function Layout({ children }: PropsWithChildren) {
2121
);
2222
}
2323

24-
Layout.Grow = function ({ children }: PropsWithChildren) {
24+
Layout.Grow = function LayoutGrow({ children }: PropsWithChildren) {
2525
return (
2626
<div style={{ flexGrow: 1, position: 'relative', overflow: 'hidden' }}>
2727
{children}
2828
</div>
2929
);
3030
};
3131

32-
Layout.Fixed = function ({
32+
Layout.Fixed = function LayoutFixed({
3333
children,
3434
shadowBottom,
3535
shadowTop,

src/renderer/components/OptionList/OptionListItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface OptionListItemProps {
1414
tick?: boolean;
1515
destructive?: boolean;
1616
separator?: boolean;
17-
onClick?: (e: React.MouseEvent) => void;
17+
onClick?: (e: React.MouseEvent) => Promise<void> | void;
1818
}
1919

2020
export default function OptionListItem({

src/renderer/components/ResizableTable/TableCellContent.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
}
3232

3333
.mono {
34-
font-family: CascadiaCode;
34+
font-family: CascadiaCode, sans-serif;
3535
font-weight: 300;
3636
color: var(--color-table-cell-code);
3737
}

src/renderer/screens/DatabaseScreen/QueryResultViewer/QueryResultTable.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ function QueryResultTable({
8282
return {};
8383
}, [result, schema, currentDatabase]);
8484

85-
if (!headers || !result) {
86-
return <div>No result</div>;
87-
}
88-
8985
const headerMemo = useMemo(() => {
9086
function getInitialSizeByHeaderType(_: number, header: QueryResultHeader) {
9187
if (header.type.type === 'number') {
@@ -152,6 +148,10 @@ function QueryResultTable({
152148
});
153149
}, [removeRowsIndex, data]);
154150

151+
if (!headers || !result) {
152+
return <div>No result</div>;
153+
}
154+
155155
return (
156156
<div className={styles.container} onContextMenu={handleContextMenu}>
157157
<OptimizeTable

0 commit comments

Comments
 (0)