Skip to content

a minimal resizable container for the container size problem#262

Open
oheil wants to merge 1 commit intoqueryverse:masterfrom
oheil:resizable-container
Open

a minimal resizable container for the container size problem#262
oheil wants to merge 1 commit intoqueryverse:masterfrom
oheil:resizable-container

Conversation

@oheil
Copy link
Copy Markdown
Contributor

@oheil oheil commented Jan 19, 2020

This is an experimental proposal for this issue:
#253

It produces a resizable div container for every plot and fires a window resized event if the div size has changed. It is using minimal JavaScript and works in latest Firefox and Chrome, not in Edge.

How do you like it?

@davidanthoff
Copy link
Copy Markdown
Member

I have to admit that I still hope that might be solvable in the vega/vega-lite code without us going through so many hoops. If not, then I guess we'll have to go with something like this... I do think it would have to work on all browsers though, including Edge...

@oheil
Copy link
Copy Markdown
Contributor Author

oheil commented Jan 20, 2020

Yes, I fully concur.
The current situation is:

  1. div container with undefined size
    • VegaLite size option "container" does not work
  2. setting a single div container size to 100%
    • VegaLite Editor Menu missplaced, outside of visible area
  3. resizable div container
    • additional special JavaScript code (complex, browser compatibility)
    • visibility of the resize widget (lower right corner) bad
    • initial size of the container may not be appropriate (e.g. if plot is small)

further discussion: #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants