clean up Docker containers, logs directory for before integration tests#44
Merged
marten-seemann merged 2 commits intomasterfrom Jun 30, 2025
Merged
clean up Docker containers, logs directory for before integration tests#44marten-seemann merged 2 commits intomasterfrom
marten-seemann merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a dedicated cleanup step for Docker containers and improves log directory handling before running integration tests.
- Introduce
clean-containerstarget and hook it into each test target - Add argument validation and directory reset in
copylogstarget
Comments suppressed due to low confidence (1)
integration/Makefile:58
- [nitpick] Consider renaming the variable
targetto uppercase (e.g.,TARGET) or a more descriptive name likeLOG_DIRto avoid confusion with file targets and improve clarity.
if [ -z "$(target)" ]; then echo "target directory not specified"; exit 1; fi
| rm proxy/key.pem proxy/cert.pem || true | ||
|
|
||
| ping: | ||
| clean-containers: |
There was a problem hiding this comment.
Add clean-containers to the .PHONY declaration so Make treats it as a phony target and avoids conflicts with files of the same name.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 87.96% 88.38% +0.41%
==========================================
Files 8 8
Lines 673 680 +7
==========================================
+ Hits 592 601 +9
+ Misses 62 60 -2
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.