Add openssl docker image for interop testing #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I see you have another interop test blocked on capacity due to the github matrix job limit. Do you have a strategy in mind for how to address that? I may be able to help |
Collaborator
|
Unfortunately, this requires a rather large refactoring of the workflow. This won't happen as long as the interop runner is unfunded. If your company is able to provide funding, please contact me directly. |
Contributor
|
You might want to look into using https://github.com/cloudposse/github-action-matrix-extended. |
lxin
added a commit
to lxin/quic-interop-runner
that referenced
this pull request
Feb 12, 2025
This reusable workflow groups interop tests by client, improving organization. More importantly, it works around the 256-job limit in the GitHub Actions' matrix strategy, allowing additional images to be included in implementations.json. This approach requires minimal changes to interop.yml, primarily moving the tests section into interop-tests.yml. The workflow now matrices over all clients, passing a single client and all servers to interop-tests.yml per run. The approach is inspired by: https://github.com/lxin/github-action-matrix-extended and suggested by Lars Eggert in quic-interop#402 Suggested-by: Lars Eggert <lars@eggert.org> Signed-off-by: Xin Long <lucien.xin@gmail.com>
lxin
added a commit
to lxin/quic-interop-runner
that referenced
this pull request
Feb 12, 2025
This reusable workflow groups interop tests by client, improving organization. More importantly, it works around the 256-job limit in the GitHub Actions' matrix strategy, allowing additional images to be included in implementations.json. This approach requires minimal changes to interop.yml, primarily moving the tests section into interop-tests.yml. The workflow now matrices over all clients, passing a single client and all servers to interop-tests.yml per run. The approach is inspired by: https://github.com/lxin/github-action-matrix-extended and suggested by Lars Eggert in quic-interop#402 Suggested-by: Lars Eggert <lars@eggert.org> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for all your great interop work
Add OpenSSL to the interop test matrix.