Rope Fix for single subfunction signature#816
Open
abhishek-singh591 wants to merge 25 commits intoquic:mainfrom
Open
Rope Fix for single subfunction signature#816abhishek-singh591 wants to merge 25 commits intoquic:mainfrom
abhishek-singh591 wants to merge 25 commits intoquic:mainfrom
Conversation
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
abhishek-singh591
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Contributor
|
nit: pls run the lint and format. |
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
quic-rishinr
requested changes
Mar 23, 2026
QEfficient/transformers/models/llama_swiftkv/modeling_llama_swiftkv.py
Outdated
Show resolved
Hide resolved
| all_self_attentions = () if output_attentions else None | ||
| all_hidden_states = () if output_hidden_states else None | ||
|
|
||
| rotary_emb = QEffFalconRotaryEmbedding(config=self.config) |
Contributor
There was a problem hiding this comment.
Can we move out of forward method and put it in qeff_init of QEffFalconModel class?
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the Rotary Position Embedding (RoPE) fix, ensuring that models generate a single unified subfunction signature during ONNX export.
Models Status After Applying the Fix
Models now producing a single subfunction signature
All causal LMs tested in the associated test file are functioning correctly, except those listed below.
Models still producing two different subfunction signatures
The following models continue to emit multiple subfunction signatures and require additional investigation:
Models with issues unrelated to the RoPE fix
These models have separate problems that need to be addressed independently: