fix span E111

Now if there is a missing body for a class, the error points to the end of the class defintion where body should start

Author: ahmafi

src/quick-lint-js/parse.h

@@ -1415,7 +1415,6 @@ class parser {
   template <QLJS_PARSE_VISITOR Visitor>
   void parse_and_visit_class(Visitor &v, name_requirement require_name) {
     QLJS_ASSERT(this->peek().type == token_type::kw_class);
-    const char8 *class_keyword_begin = this->peek().begin;
 
     this->parse_and_visit_class_heading(v, /*require_name=*/require_name);
 
@@ -1431,13 +1430,14 @@ class parser {
       this->skip();
       break;
 
-    default:
+    default: {
+      const char8 *here = this->lexer_.end_of_previous_token();
       this->error_reporter_->report(error_missing_body_for_class{
-          .class_keyword_and_name_and_heritage = source_code_span(
-              class_keyword_begin, this->lexer_.end_of_previous_token()),
+          .class_keyword_and_name_and_heritage = source_code_span(here, here),
       });
       break;
     }
+    }
   }
 
   // Parse the 'class' keyword, the class's optional name, and any extends

test/test-parse-class.cpp

@@ -106,10 +106,11 @@ TEST(test_parse, class_statement_requires_a_body) {
     parser p(&code, &v);
     EXPECT_TRUE(p.parse_and_visit_statement(v));
     EXPECT_THAT(v.visits, ElementsAre("visit_variable_declaration"));  // C
-    EXPECT_THAT(v.errors, ElementsAre(ERROR_TYPE_FIELD(
-                              error_missing_body_for_class,
-                              class_keyword_and_name_and_heritage,
-                              offsets_matcher(&code, 0, u8"class C"))));
+    EXPECT_THAT(
+        v.errors,
+        ElementsAre(ERROR_TYPE_FIELD(
+            error_missing_body_for_class, class_keyword_and_name_and_heritage,
+            offsets_matcher(&code, strlen(u8"class C"), u8""))));
   }
 
   {
@@ -118,14 +119,15 @@ TEST(test_parse, class_statement_requires_a_body) {
     parser p(&code, &v);
     EXPECT_TRUE(p.parse_and_visit_statement(v));
     EXPECT_THAT(v.visits, IsEmpty());
-    EXPECT_THAT(v.errors,
-                UnorderedElementsAre(
-                    ERROR_TYPE_FIELD(error_missing_name_in_class_statement,
-                                     class_keyword,
-                                     offsets_matcher(&code, 0, u8"class")),
-                    ERROR_TYPE_FIELD(error_missing_body_for_class,
-                                     class_keyword_and_name_and_heritage,
-                                     offsets_matcher(&code, 0, u8"class"))));
+    EXPECT_THAT(
+        v.errors,
+        UnorderedElementsAre(
+            ERROR_TYPE_FIELD(error_missing_name_in_class_statement,
+                             class_keyword,
+                             offsets_matcher(&code, 0, u8"class")),
+            ERROR_TYPE_FIELD(error_missing_body_for_class,
+                             class_keyword_and_name_and_heritage,
+                             offsets_matcher(&code, strlen(u8"class"), u8""))));
   }
 }