Skip to content

Add basic search functionality #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 37 additions & 31 deletions src/components/SearchInput.tsx
Original file line number Diff line number Diff line change
@@ -1,58 +1,64 @@
import { SearchIcon } from "./Icons";
import { useState, useCallback } from "react";
import { useSearchParams, useNavigate } from "react-router-dom";
import { useSearchParams, useNavigate, useLocation } from "react-router-dom";

const SearchInput = () => {
const navigate = useNavigate();
const location = useLocation();
const [searchParams, setSearchParams] = useSearchParams();
const [searchValue, setSearchValue] = useState(searchParams.get("q") || "");

const debouncedSearch = useCallback(
debounce((query: string) => {
if (query) {
setSearchParams({ q: query });
navigate(`/search?q=${encodeURIComponent(query.trim().toLowerCase())}`);
} else {
const navigateToSearch = useCallback(
(query: string, isCompletedSearch = false) => {
const trimmedQuery = query.trim().toLowerCase();

if (!trimmedQuery) {
// Remove search params and navigate to home if query is empty
setSearchParams({});
navigate("/");
navigate("/", { replace: true });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one shouldn't replace

return;
}
}, 200),
[setSearchParams, navigate]
);

const handleSearch = (e: React.ChangeEvent<HTMLInputElement>) => {
const value = e.target.value;
setSearchValue(value);
debouncedSearch(value);
};
// Set the search params with the query
// Use replace: true for keypresses (when isCompletedSearch is false)
setSearchParams({ q: trimmedQuery }, { replace: !isCompletedSearch });

// Only navigate if we're not already on the search page
if (location.pathname !== "/search") {
navigate("/search", {
replace: isCompletedSearch || location.pathname === "/search",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should always be false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at it next year, I've been going crazy for the past four hours trying to get this all to behave.

});
}
},
[navigate, location.pathname, setSearchParams]
);

return (
<div className="search-field">
<form
onSubmit={(e) => {
e.preventDefault();
navigateToSearch(searchValue, true);
}}
className="search-field"
>
<label htmlFor="search">
<SearchIcon />
</label>
<input
type="search"
id="search"
value={searchValue}
onChange={handleSearch}
onChange={(e) => {
const newValue = e.target.value;
setSearchValue(newValue);
navigateToSearch(newValue, false);
}}
onBlur={() => navigateToSearch(searchValue, true)}
placeholder="Search here..."
autoComplete="off"
/>
</div>
</form>
);
};

// Debounce utility function
function debounce<T extends (...args: any[]) => any>(
func: T,
wait: number
): (...args: Parameters<T>) => void {
let timeout: ReturnType<typeof setTimeout>;
return (...args: Parameters<T>) => {
clearTimeout(timeout);
timeout = setTimeout(() => func(...args), wait);
};
}

export default SearchInput;