build(deps): bump immutable and @graphql-tools/relay-operation-optimizer in /catalog#4755
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
build(deps): bump immutable and @graphql-tools/relay-operation-optimizer in /catalog#4755dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
Additional Comments (1)
This will break the Redux DevTools state transformer and the Sentry enhancer's The fix is to replace |
Bumps [immutable](https://github.com/immutable-js/immutable-js) to 5.1.5 and updates ancestor dependency [@graphql-tools/relay-operation-optimizer](https://github.com/ardatan/graphql-tools/tree/HEAD/packages/relay-operation-optimizer). These dependencies need to be updated together. Updates `immutable` from 3.8.2 to 5.1.5 - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v3.8.2...v5.1.5) Updates `@graphql-tools/relay-operation-optimizer` from 6.3.0 to 6.5.18 - [Release notes](https://github.com/ardatan/graphql-tools/releases) - [Changelog](https://github.com/ardatan/graphql-tools/blob/master/packages/relay-operation-optimizer/CHANGELOG.md) - [Commits](https://github.com/ardatan/graphql-tools/commits/@graphql-tools/relay-operation-optimizer@6.5.18/packages/relay-operation-optimizer) --- updated-dependencies: - dependency-name: immutable dependency-version: 5.1.5 dependency-type: direct:production - dependency-name: "@graphql-tools/relay-operation-optimizer" dependency-version: 6.5.18 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
92c5d59 to
2b470b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps immutable to 5.1.5 and updates ancestor dependency @graphql-tools/relay-operation-optimizer. These dependencies need to be updated together.
Updates
immutablefrom 3.8.2 to 5.1.5Release notes
Sourced from immutable's releases.
... (truncated)
Changelog
Sourced from immutable's changelog.
... (truncated)
Commits
b37b8555.1.516b3313Merge commit from forkfd2ef49fix new proto key injection6734b7bfix Prototype Pollution in mergeDeep, toJS, etc.6f772deMerge pull request #2175 from immutable-js/dependabot/npm_and_yarn/rollup-4.59.05f3dc61Bump rollup from 4.34.8 to 4.59.0049a594Merge pull request #2173 from immutable-js/dependabot/npm_and_yarn/lodash-4.1...2481a77Merge pull request #2172 from mrazauskas/update-tstycheeb04779Bump lodash from 4.17.21 to 4.17.23b973bf3formatMaintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for immutable since your current version.
Updates
@graphql-tools/relay-operation-optimizerfrom 6.3.0 to 6.5.18Changelog
Sourced from
@graphql-tools/relay-operation-optimizer's changelog.... (truncated)
Commits
921abaechore(release): update monorepo packages versions (#5167)1c95368Use ranged versions for dependencies79afd0bchore(release): update monorepo packages versions (#5024)1094ed9chore(release): update monorepo packages versions (#5018)6a7068echore(release): update monorepo packages versions (#4962)9436db0chore(release): update monorepo packages versions (#4888)90011f0chore(release): update monorepo packages versions (#4884)353be6eUpcoming Release Changes (#4843)79b126bchore(release): update monorepo packages versions (#4826)74e28b6chore(release): update monorepo packages versions (#4815)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Greptile Summary
This Dependabot PR bumps
immutablefrom v3.8.2 to v5.1.5 (addressing a Prototype Pollution security vulnerability) and updates its co-dependent@graphql-tools/relay-operation-optimizerfrom 6.3.0 to 6.5.18.However, the upgrade spans two major versions (v3 → v5) and introduces a breaking API change that will cause a runtime crash: the
Iterablenamed export was removed in immutable-js v4 and replaced withCollection. The code incatalog/app/utils/Store.jsximports and usesIterable.isIterable(), which will throw aTypeErroron every Redux dispatch, breaking both Redux DevTools and the Sentry error enhancer across the entire application.Other immutable-js usages (
fromJS,Map,List,.get(),.getIn(), etc.) are compatible with v5. The fix is a single-line rename inStore.jsx: replaceIterablewithCollectionand update the call toCollection.isCollection().Not safe to merge without fixing the
Store.jsxbreaking change.Confidence Score: 1/5
immutableupgrade from v3 → v5 removes theIterableAPI that is actively used inStore.jsx. When the stateTransformer function executes (which happens on every Redux action), it will throwTypeError: Cannot read properties of undefined (reading 'isIterable'), crashing Redux DevTools and the Sentry error enhancer. This is a critical, app-wide runtime error. The fix is a one-line change inStore.jsx, but the PR cannot be merged without it.catalog/app/utils/Store.jsx— must replaceIterablewithCollectionbefore mergeFlowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["immutable v3.8.2 → v5.1.5 bump"] --> B["Security fix\n(Prototype Pollution)"] A --> C["Breaking API changes\n(v3 → v4 → v5)"] C --> D["Iterable renamed to Collection\n(removed in v4+)"] D --> E["Store.jsx imports Iterable\nfrom immutable"] E --> F["Iterable is undefined at runtime"] F --> G["TypeError: Cannot read properties\nof undefined 'isIterable'\n⚠️ Crash on every Redux dispatch"] A --> H["Other usages (fromJS, Map, List,\nget, getIn, toJS) — compatible ✅"] A --> I["@ardatan/relay-compiler\ngets isolated immutable@3.7.6 ✅"]Last reviewed commit: 92c5d59