Skip to content

Minio demo#4774

Draft
kevinemoore wants to merge 2 commits intomasterfrom
minio-demo
Draft

Minio demo#4774
kevinemoore wants to merge 2 commits intomasterfrom
minio-demo

Conversation

@kevinemoore
Copy link
Copy Markdown
Contributor

Description

TODO

  • Unit tests
  • Security: Confirm that this change meets security best practices and does not violate the security model
  • Open and Embed: Confirm that this change doesn't break Open variant and Embed widget
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quilt.bio)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Kevin Moore added 2 commits October 16, 2023 08:59
To support Min.io and passing in S3 credentials, allow users to pass their own S3 clients for accessing specific buckets.

TODO: how will this support bucket-to-bucket copy across different clients?
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.55%. Comparing base (b15c2de) to head (be79501).
⚠️ Report is 191 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b15c2de) and HEAD (be79501). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (b15c2de) HEAD (be79501)
lambda 22 14
api-python 20 0
catalog 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4774      +/-   ##
==========================================
- Coverage   37.63%   28.55%   -9.09%     
==========================================
  Files         816      724      -92     
  Lines       36117    24677   -11440     
  Branches     5895     5723     -172     
==========================================
- Hits        13592     7046    -6546     
+ Misses      21301    15628    -5673     
- Partials     1224     2003     +779     
Flag Coverage Δ
api-python ?
catalog 19.53% <ø> (+2.25%) ⬆️
lambda 96.63% <ø> (+4.03%) ⬆️
py-shared 98.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant