-
-
Notifications
You must be signed in to change notification settings - Fork 483
Allow running perf client and server within dockers #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add set -eu
to the shell scripts for robustness?
51e8098
to
c2c124e
Compare
This gets further now, but still fails before doing any testing:
|
i will rebase the work as it is quite old and see if i also have the issue. |
c2c124e
to
43318fb
Compare
2ada371
to
82550f8
Compare
6b4465d
to
75e5e46
Compare
4e561dd
to
7c76c4c
Compare
7c76c4c
to
2b0f31e
Compare
I added support for extra args for |
I appreciate the efforts, but not sure it makes sense to maintain this in this repository... |
i can move it to a dedicated repository, just tell me |
@Ralith thoughts? |
I guess the benefit of it being part of this repo is if we wanna do some sort of regression test to make sure internal tweaks don't make it noticeably slower? But by default it seems like the kind of thing that doesn't need to be merged into this repo. But a regression test as such could be valuable... |
2b0f31e
to
3ffa72e
Compare
While I very much appreciate this work, I lean towards keeping this externally-maintained for now, just because I think we're not likely to use it much personally and it will probably bitrot as a result. Regression tests are attractive, but they need to be built and automated and operated in a controlled environment, none of which can be taken for granted. |
Hi, i will move it to its own repository. |
Add a way to run perf_client and perf_server within two dockers with optional simulated latency.
To build the binaries and the docker, use :
build.sh
To launch the server, use :
./run-server.sh -l 10 -L 0.1 -c -o
This will :
To launch the client, use :
./run-client.sh -l 10 -L 0.1
This will launch perf_client for 5sec with a simulated latency of 10ms (we will the have a RTT of 10ms) and a packet loss of 0.1%.
/!\ For now the GSO is disabled otherwise wireshark is not capable of deciphering packets.