proto: Make BytesSource private #2233
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no public APIs that accept BytesSource. This commit makes it not be re-exported publically.
djc
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no public APIs that accept BytesSource. This commit makes it not be re-exported publically.
I am cherry-picking this commit from #2230. Djc and Ralith both seemed to agree in that PR that, although this is technically a breaking change, we're ok with acting like it's not because we assume nobody is using
BytesSource(because we provide no way to use it and seemingly made it public by accident).I am splitting this out from 2230 because that way we don't have to think about that quirk of the change in 2230.
Closes #2228.