Skip to content

Throw compile time error for missing runtime #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+6 −2
Closed

Throw compile time error for missing runtime #2450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1085361
feat: throw compile time error for missing runtime
naveen28204280 Nov 22, 2025
4915438
Merge branch 'quinn-rs:main' into 2424
naveen28204280 Nov 25, 2025
228ba79
fix: typo in no-runtime-found compile error
naveen28204280 Nov 24, 2025
adfbd9e
fix: edit job lint to add feature runtime-tokio
naveen28204280 Nov 25, 2025
0a7aaca
Merge branch 'quinn-rs:main' into 2424
naveen28204280 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion quinn/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ rustls-ring = ["dep:rustls", "ring", "proto/rustls-ring", "proto/ring"]
ring = ["proto/ring"]
runtime-tokio = ["tokio/time", "tokio/rt", "tokio/net"]
runtime-smol = ["dep:async-io", "dep:smol"]

# Allow users to declare a custom runtimne
custom-runtime = []
# Configure `tracing` to log events via `log` if no `tracing` subscriber exists.
tracing-log = ["tracing/log", "proto/tracing-log", "udp/tracing-log"]
# Enable rustls logging
Expand Down
3 changes: 3 additions & 0 deletions quinn/src/runtime/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ use udp::{RecvMeta, Transmit};

use crate::Instant;

#[cfg(not(any(feature = "runtime-tokio", feature = "runtime-smol", feature = "custom-runtime")))]
compile_error!("no async runtime found. Please enable a runtimse such as runtime-tokio, runtime-smol or custom-runtime");
Copy link
Collaborator

@Ralith Ralith Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "runtimse". Let's also word this as "a runtime feature" to provide a clearer breadcrumb to users who might not know what we're talking about.

Also please be consistent about capitalization and punctuation: if the text contains multiple sentences, then the first letter should be capitalized and there should be a trailing period.


/// Abstracts I/O and timer operations for runtime independence
pub trait Runtime: Send + Sync + Debug + 'static {
/// Construct a timer that will expire at `i`
Expand Down
Loading