-
Notifications
You must be signed in to change notification settings - Fork 10
SavedScenario User Management via Engine #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ded041a to
2e950cc
Compare
29cf8e2 to
ec68d83
Compare
ec68d83 to
a180647
Compare
noracato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding all CRUD operations is a great idea.
Let's get a clear grip on who does what, and who holds the truth in the end. Like you said for SavedScenarios it should be myETM who's in control. Maybe we can draft a diagram about interactions and which app has which initiative.
6b8ee56 to
dcaf97b
Compare
noracato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! I had just one small doubt about the preset user data. Could you explain your thought process there?
dcaf97b to
fcf7447
Compare
…ry params from myetm
fcf7447 to
861c20d
Compare
Description
Implements a pass-through API that proxies SavedScenario user management requests to MyETM.
These changes, along with this Myetm PR allow users to manage roles on SavedScenarios via the Engine, and solidify the user coupling functionality so accounts are properly coupled based on the callback actions in MyETM.
Key changes:
/api/v3/saved_scenarios/:id/users)my_etm_clientfor other similar Faraday calls)Still to do
Relevant for this pyetm PR
Closes #1687