[DIN-749] Add feature to delete nulls in overrides#30
Open
[DIN-749] Add feature to delete nulls in overrides#30
Conversation
|
dutrevis
reviewed
Dec 12, 2023
Comment on lines
+120
to
+121
| elif value is None: | ||
| source.pop(key, None) |
Contributor
There was a problem hiding this comment.
Would we want to choose wether the key is removed or it's persisted with the None value? There may be some situations where we would like to keep the key with the None, or am I being to picky?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why? 📖
There is currently no way to remove a key that was previously added using overrides. This is a limitation that we can solve by removing null values.
What? 🔧
Type of change 🗄️
How everything was tested? 📏
Unit tests
Checklist 📝