Merged
Conversation
bmish
commented
Jun 23, 2025
Comment on lines
+85
to
+102
| /* istanbul ignore next */ | ||
| if (callExprNode.type !== "CallExpression") { | ||
| return null; | ||
| } | ||
| /* istanbul ignore next */ | ||
| if (callExprNode.callee.type !== "MemberExpression") { | ||
| return null; | ||
| } | ||
| /* istanbul ignore next */ | ||
| if (callExprNode.callee.object.type !== "Identifier") { | ||
| return null; | ||
| } | ||
| /* istanbul ignore next */ | ||
| if ( | ||
| callExprNode.callee.property.type !== "Identifier" | ||
| ) { | ||
| return null; | ||
| } |
Member
Author
There was a problem hiding this comment.
This fixes an actual crash caught by eslint-remote-tester:
Repository: l10n-tw/canvas-lms
[143](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:144)
Rule: qunit/no-compare-relation-boolean
[144](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:145)
Message: Cannot read properties of undefined (reading 'name')
[145](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:146)
Occurred while linting /home/runner/work/eslint-plugin-qunit/eslint-plugin-qunit/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/l10n-tw/canvas-lms/spec/javascripts/jsx/shared/helpers/JQuerySelectorCacheSpec.js:38
[146](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:147)
Rule: "qunit/no-compare-relation-boolean"
[147](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:148)
Path: l10n-tw/canvas-lms/spec/javascripts/jsx/shared/helpers/JQuerySelectorCacheSpec.js
[148](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:149)
Link: https://github.com/l10n-tw/canvas-lms/blob/HEAD/spec/javascripts/jsx/shared/helpers/JQuerySelectorCacheSpec.js#L38
[149](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:150)
[150](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:151)
36 | test('returns a jquery selector', () => {
[151](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:152)
37 | const response = selectorCache.get('#foo')
[152](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:153)
> 38 | strictEqual(response instanceof $, true)
[153](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:154)
39 | })
[154](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:155)
40 |
[155](https://github.com/qunitjs/eslint-plugin-qunit/actions/runs/15812921911/job/44566834381?pr=573#step:5:156)
41 | test('returns the selector for the given element', () => {
This fix is pulled from the TypeScript PR: #571
Pull Request Test Coverage Report for Build 15890657328Details
💛 - Coveralls |
Member
Author
|
I'm going to merge this now for a forthcoming minor release. I'm open to receiving and addressing feedback after the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades all the eslint plugins so we can use their flat configs for ESLint v9.
Everything is passing except Node 16 because ESLint v9 RuleTester uses structuredClone which is only available in Node 17+. So for now I've stopped testing under Node 16 although we will still support it until the next major release.