Skip to content

refactor: remove workaround for package.json compiled path in index.js #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: remove workaround for package.json compiled path in index.js #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/configs/recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use strict";

const plugin = require("../../index.js");
const plugin = require("../index.js");

module.exports = {
plugins: { qunit: plugin },
Expand Down
12 changes: 3 additions & 9 deletions index.js → lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,17 @@
"use strict";

const requireIndex = require("requireindex");
const path = require("node:path");

const pathParts = __dirname.split(path.sep);
const pkg =
pathParts[pathParts.length - 1] === "dist"
? // @ts-expect-error -- TODO: ESM/TypeScript conversion should fix this.
require("../package.json") // eslint-disable-line n/no-missing-require -- this is the path when this file is compiled to dist/
: // @ts-expect-error -- TODO: ESM/TypeScript conversion should fix this.
require("./package.json");
// @ts-expect-error -- TODO: ESM/TypeScript conversion should fix this.
const pkg = require("../package.json");

module.exports = {
meta: {
name: pkg.name,
version: pkg.version,
},

rules: requireIndex(`${__dirname}/lib/rules`),
rules: requireIndex(`${__dirname}/rules`),

// eslint-disable-next-line sort-keys
configs: {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "ESLint plugin containing rules useful for QUnit tests.",
"exports": {
".": "./dist/index.js",
"./configs/*": "./dist/lib/configs/*.js"
"./configs/*": "./dist/configs/*.js"
},
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down
4 changes: 2 additions & 2 deletions tests/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
//------------------------------------------------------------------------------

const assert = require("chai").assert,
{ rules, configs } = require("../index"),
{ rules, configs } = require("../lib/index"),
fs = require("node:fs"),
path = require("node:path"),
requireIndex = require("requireindex"),
plugin = require("../index.js"),
plugin = require("../lib/index.js"),
recommendedFlatConfig = require("../lib/configs/recommended.js");

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

/* Modules */
"module": "nodenext", /* Specify what module code is generated. */
// "rootDir": "./", /* Specify the root folder within your source files. */
"rootDir": "lib/", /* Specify the root folder within your source files. */
// "moduleResolution": "node10", /* Specify how TypeScript looks up a file from a given module specifier. */
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
Expand Down
Loading