quokka-astro/quokka

NSCBC::setOutflowBoundaryLowOrder<...>(...): in the `DIR == FluxDir::X3` reflecting fallback branch, `Q_im3` is assigned three times and `Q_im4`/`Q_im5` are never populated (`src/hydro/NSCBC_outflow.hpp:427-432`; repeated assignments at `:430-432`)

#1702

· BenWibking opened

on Feb 24, 2026

NSCBC::detail::transverse_xdir_dQ_data(...): in the `AMREX_SPACEDIM == 3` z-derivative branch, the computed derivative is assigned to `dQ_dy_data` instead of `dQ_dz_data` (`src/hydro/NSCBC_outflow.hpp:132-137`, assignment at `:136`)

bug: wrong answer/failure/crash

code-audit

codex

#1701

· BenWibking opened

on Feb 24, 2026

rk_adaptive_integrate(...): ignores the return code of the initial `rhs(t0, y0, ydot0)` call used for timestep estimation (`src/math/ODEIntegrate.hpp:137`), so an RHS failure can leave `ydot0` invalid and contaminate `dt_guess` / subsequent integration control

bug: wrong answer/failure/crash

code-audit

codex

#1700

· BenWibking opened

on Feb 24, 2026

error_norm(...): weighting uses `reltol * y0[i] + abstol[i]` (`src/math/ODEIntegrate.hpp:118`) instead of `reltol * abs(y0[i]) + abstol[i]` (as in standard weighted RMS norms)

bug: wrong answer/failure/crash

code-audit

codex

#1699

· BenWibking opened

on Feb 24, 2026

interpolate2d(...): boundary-degenerate branch conditions mistakenly compare coordinate `yi` (double) instead of index `iy` (int) (`src/math/Interpolate2D.hpp:58`, `src/math/Interpolate2D.hpp:63`)

bug: wrong answer/failure/crash

code-audit

codex

#1698

· BenWibking opened

on Feb 24, 2026

particle_io::saveParticleDataToTxtFile<ContainerType>(...): gathers `particle_ids` (`src/particles/particle_IO.hpp:376`) but never writes them, and integer-component output starts at index `1` (`src/particles/particle_IO.hpp:398`) instead of `0`

code-audit

codex

particles

#1692

· BenWibking opened

on Feb 24, 2026

read_dataset(...): reads `ndims` but unconditionally indexes `dims[0..2]` when constructing the 3D table (`src/turbulence/TurbDataReader.cpp:27-30`, `:49`)

bug: wrong answer/failure/crash

code-audit

codex

#1690

· BenWibking opened

on Feb 24, 2026

PhysicsParticleDescriptor<...>::splitParticles(...): no validation that `splitFactor > 0` (`src/particles/PhysicsParticles.hpp:408-469`)

bug: wrong answer/failure/crash

code-audit

codex

particles

#1689

· BenWibking opened

on Feb 24, 2026

RadSystem::AddSourceTermsSingleGroup(...): in the `beta_order_ > 1` branch, `gasVel` is value-initialized but never populated before building the 3x3 flux-update matrix (`src/radiation/source_terms_single_group.hpp:399`, `:453-463`)

bug: wrong answer/failure/crash

code-audit

codex

#1688

· BenWibking opened

on Feb 24, 2026

AMRSimulation::ReadMetadataFile(...): uses `feholdexcept(...)` / `fesetenv(...)` for temporary FPE masking (`src/simulation.hpp:4164-4165`, `:4192`), but `YAML::LoadFile(...)` or subsequent parsing can throw before `fesetenv(...)` runs, leaving the process FPE environment altered

bug: wrong answer/failure/crash

code-audit

codex

#1684

· BenWibking opened

on Feb 24, 2026

AMRSimulation::FillCoarsePatch(...): face-centered branch still constructs cell-centered boundary functors (`setBoundaryFunctor`) and never uses `setBoundaryFunctorFaceVar` / `dir` (`src/simulation.hpp:3240-3250`), so custom face-variable physical BCs are skipped on coarse interpolation fills

bug: wrong answer/failure/crash

code-audit

codex

#1683

· BenWibking opened

on Feb 24, 2026

AMRSimulation::RemakeLevel(...): repeats the same face-BC packing bug as `MakeNewLevelFromCoarse` (`BCs_array[idim] = BCs_fc_` at `src/simulation.hpp:2416`), passing flattened BC records where per-direction BC vectors are expected

bug: wrong answer/failure/crash

code-audit

codex

#1680

· BenWibking opened

on Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NSCBC::setOutflowBoundaryLowOrder<...>(...): in the `DIR == FluxDir::X3` reflecting fallback branch, `Q_im3` is assigned three times and `Q_im4`/`Q_im5` are never populated (`src/hydro/NSCBC_outflow.hpp:427-432`; repeated assignments at `:430-432`)

NSCBC::detail::transverse_xdir_dQ_data(...): in the `AMREX_SPACEDIM == 3` z-derivative branch, the computed derivative is assigned to `dQ_dy_data` instead of `dQ_dz_data` (`src/hydro/NSCBC_outflow.hpp:132-137`, assignment at `:136`)

rk_adaptive_integrate(...): ignores the return code of the initial `rhs(t0, y0, ydot0)` call used for timestep estimation (`src/math/ODEIntegrate.hpp:137`), so an RHS failure can leave `ydot0` invalid and contaminate `dt_guess` / subsequent integration control

error_norm(...): weighting uses `reltol * y0[i] + abstol[i]` (`src/math/ODEIntegrate.hpp:118`) instead of `reltol * abs(y0[i]) + abstol[i]` (as in standard weighted RMS norms)

interpolate2d(...): boundary-degenerate branch conditions mistakenly compare coordinate `yi` (double) instead of index `iy` (int) (`src/math/Interpolate2D.hpp:58`, `src/math/Interpolate2D.hpp:63`)

particle_io::saveParticleDataToTxtFile<ContainerType>(...): gathers `particle_ids` (`src/particles/particle_IO.hpp:376`) but never writes them, and integer-component output starts at index `1` (`src/particles/particle_IO.hpp:398`) instead of `0`

read_dataset(...): reads `ndims` but unconditionally indexes `dims[0..2]` when constructing the 3D table (`src/turbulence/TurbDataReader.cpp:27-30`, `:49`)

PhysicsParticleDescriptor<...>::splitParticles(...): no validation that `splitFactor > 0` (`src/particles/PhysicsParticles.hpp:408-469`)

RadSystem::AddSourceTermsSingleGroup(...): in the `beta_order_ > 1` branch, `gasVel` is value-initialized but never populated before building the 3x3 flux-update matrix (`src/radiation/source_terms_single_group.hpp:399`, `:453-463`)

AMRSimulation::ReadMetadataFile(...): uses `feholdexcept(...)` / `fesetenv(...)` for temporary FPE masking (`src/simulation.hpp:4164-4165`, `:4192`), but `YAML::LoadFile(...)` or subsequent parsing can throw before `fesetenv(...)` runs, leaving the process FPE environment altered

AMRSimulation::FillCoarsePatch(...): face-centered branch still constructs cell-centered boundary functors (`setBoundaryFunctor`) and never uses `setBoundaryFunctorFaceVar` / `dir` (`src/simulation.hpp:3240-3250`), so custom face-variable physical BCs are skipped on coarse interpolation fills

AMRSimulation::RemakeLevel(...): repeats the same face-BC packing bug as `MakeNewLevelFromCoarse` (`BCs_array[idim] = BCs_fc_` at `src/simulation.hpp:2416`), passing flattened BC records where per-direction BC vectors are expected

Issues

Search results