feat: add confirmation box before forgetting a room #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
requested changes
Mar 19, 2018
client/roomlistdock.cpp
Outdated
| room->connection()->forgetRoom(room->id()); | ||
| if (auto room = getSelectedRoom()) { | ||
| QMessageBox confirmBox(QMessageBox::Question, | ||
| tr("Are you sure?"), |
There was a problem hiding this comment.
I'd rather use something like "Really forget the room?".
client/roomlistdock.cpp
Outdated
| tr("Do you want to forget the room %1").arg(room->displayName()), | ||
| QMessageBox::Yes|QMessageBox::No, this); | ||
| if (confirmBox.exec() == QMessageBox::No) | ||
| ; |
There was a problem hiding this comment.
Just use comparison with QMessageBox::Yes and omit the else branch entirely instead?
client/roomlistdock.cpp
Outdated
| if (auto room = getSelectedRoom()) { | ||
| QMessageBox confirmBox(QMessageBox::Question, | ||
| tr("Are you sure?"), | ||
| tr("Do you want to forget the room %1").arg(room->displayName()), |
There was a problem hiding this comment.
I'd rather force a "disambiguated" name here (meaning - attach canonical alias even in the case when the name exists, and even add a room id if neither room name nor canonical alias exist). The latter one is dubious because people don't know room id's but most people certainly know canonical aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236