Skip to content

Conversation

@rpallai
Copy link
Contributor

@rpallai rpallai commented Jun 17, 2019

var yDelta = wheel.angleDelta.y / 120 * 100

I don't like this fixed multiplier but even so it's a good start and works well for me.

@rpallai rpallai force-pushed the fasterwheelscroll branch from edd2346 to 4fbcd05 Compare June 22, 2019 23:08
@rpallai
Copy link
Contributor Author

rpallai commented Jun 22, 2019

The new patch doesn't mess up horizontal wheel scroll of oversized textFields.

@rpallai rpallai force-pushed the fasterwheelscroll branch 2 times, most recently from 62f82b5 to a127cef Compare June 25, 2019 13:18
@rpallai
Copy link
Contributor Author

rpallai commented Jun 25, 2019

It doesn't mess cursor shape over the timeline.

@rpallai rpallai force-pushed the fasterwheelscroll branch from a127cef to 7c8c3ee Compare June 25, 2019 14:56
@rpallai
Copy link
Contributor Author

rpallai commented Jun 25, 2019

It follows the previous approach but provides a more complete implementation.

An easy-going vertical wheel scroll over the timeline is expected by
users even if shuttleDial is enabled.
@rpallai rpallai force-pushed the fasterwheelscroll branch from 7c8c3ee to dbda393 Compare June 27, 2019 08:02
@rpallai
Copy link
Contributor Author

rpallai commented Jun 27, 2019

It seemed like a low-hanging fruit but it isn't.

The previous approach required all content elements to tile the message with mouse areas which isn't sustainable. Instead of this tiling I decided to use of "fallback" areas at the highest level. It's easier, more complete and transparent for content widgets.

The newly introduced type called TimelineMouseArea will be used more extensivly in my behaviour changing patches in the future. This is why I don't avoid this new type here.

@rpallai
Copy link
Contributor Author

rpallai commented Jun 27, 2019

PR #606 contains this along with other depending mouse handling improvements. I pushed as a whole to save time on review cycles.

@rpallai rpallai closed this Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant