Add support for xyz.amorgan.blurhash in ImageContent #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy to see the blurhash generation code in the library too - would you mind moving it over here from the NeoChat MR? :) |
Sure can! |
redstrate
force-pushed
the
work/redstrate/blurhash-support
branch
from
0ea5d48 to
d7f2d33
Compare
|
Okay the blurhash implementation has been moved here, will update the NeoChat MR accordingly |
redstrate
force-pushed
the
work/redstrate/blurhash-support
branch
2 times, most recently
from
b887bac to
7a4ddda
Compare
KitsuneRal
requested changes
Nov 20, 2023
redstrate
force-pushed
the
work/redstrate/blurhash-support
branch
3 times, most recently
from
b800ffb to
8bc55f0
Compare
KitsuneRal
reviewed
Jul 21, 2024
This adds an optional key to ImageContent, for displaying a blurhash on the client before an image is loaded.
redstrate
force-pushed
the
work/redstrate/blurhash-support
branch
from
8bc55f0 to
fd7cd98
Compare
So every client that wants to implement blurhashes doesn't have to copy this file over and over.
redstrate
force-pushed
the
work/redstrate/blurhash-support
branch
from
fd7cd98 to
e54b582
Compare
|
Okay I took a look at it once again and the same question from above holds: what's the point of having the protected interface and the whole class in fact? Why not a namespace with two functions and the rest pulled into the .cpp backend? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional key to ImageContent, for displaying a blurhash on the client before an image is loaded.
Example consumer in Neochat: https://invent.kde.org/network/neochat/-/merge_requests/1151