Add support for profile fields (MSC4133) #869
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the now-somewhat-supported but still unstable MSC for profile fields. Mostly consisting of jobs for clients, some capability support and logic for determining whether a profile field is supported or not.
KitsuneRal
reviewed
Mar 14, 2025
| //! A list of disallowed profile field keys. | ||
| QList<QString> disallowed; | ||
| }; | ||
|
|
There was a problem hiding this comment.
The contents of csapi/ are generated from API definitions (see CODE_GENERATION.md) - I understand it makes the whole process a bit more tedious but I'd rather wait for matrix-org/matrix-spec#2071 to get merged and then we're going to get those definitions "for free", just by virtue of rebasing the main branch in https://github.com/quotient-im/matrix-spec
Comment on lines
+1983
to
+1998
| // If the capability is missing, assume we are allowed to edit any profile field | ||
| if (!d->capabilities.profileFields) { | ||
| return true; | ||
| } | ||
|
|
||
| // If it's explicitly in the allow list | ||
| if (d->capabilities.profileFields->allowed.contains(key)) { | ||
| return true; | ||
| } | ||
|
|
||
| // As long as it's not explicitly disallowed | ||
| if (d->capabilities.profileFields->disallowed.contains(key)) { | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
Suggested change
| // If the capability is missing, assume we are allowed to edit any profile field | |
| if (!d->capabilities.profileFields) { | |
| return true; | |
| } | |
| // If it's explicitly in the allow list | |
| if (d->capabilities.profileFields->allowed.contains(key)) { | |
| return true; | |
| } | |
| // As long as it's not explicitly disallowed | |
| if (d->capabilities.profileFields->disallowed.contains(key)) { | |
| return false; | |
| } | |
| return true; | |
| // If the capability is missing, assume we are allowed to edit any profile field; otherwise, | |
| // it should either be explicitly allowed or NOT explicitly disallowed | |
| return (!d->capabilities.profileFields || d->capabilities.profileFields->allowed.contains(key)) | |
| && !d->capabilities.profileFields->disallowed.contains(key)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the now-somewhat-supported but still unstable MSC for profile fields. Mostly consisting of jobs for clients, some capability support and logic for determining whether a profile field is supported or not.