Implement presence #903
Draft
Implement presence #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
requested changes
Aug 20, 2025
| namespace Quotient | ||
| { | ||
|
|
||
| class QUOTIENT_API PresenceEvent : public Quotient::Event { |
There was a problem hiding this comment.
Suggested change
| class QUOTIENT_API PresenceEvent : public Quotient::Event { | |
| class QUOTIENT_API PresenceEvent : public Event { |
| // To be implemented | ||
| for (const auto &event : presenceData) { | ||
| auto presenceEvent = eventCast<const PresenceEvent>(event); | ||
| auto sender = presenceEvent->fullJson()[u"sender"_s].toString(); // TODO ? |
There was a problem hiding this comment.
Suggested change
| auto sender = presenceEvent->fullJson()[u"sender"_s].toString(); // TODO ? | |
| auto sender = presenceEvent->senderId(); |
Calling it senderId() to align with RoomEvent.
| QUO_EVENT(PresenceEvent, "m.presence") | ||
|
|
||
| using Event::Event; | ||
|
|
There was a problem hiding this comment.
Suggested change
| QString senderId() const { return fullJson()[SenderKey].toString(); } |
| presentUsers.removeAll(sender); | ||
| } | ||
| } | ||
| Q_EMIT q->presenceChanged(); |
There was a problem hiding this comment.
Suggested change
| Q_EMIT q->presenceChanged(); | |
| emit q->presenceChanged(); |
|
FWIW, this is still very much a draft, in large parts because i still need to figure out what the various fields in the presence event actually mean; the spec is very unclear here. I also want to change the implementation to store the latest presence event for each user instead and just use that to figure out whether the user is online |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.