Skip to content

Conversation

@alanocallaghan
Copy link
Contributor

@alanocallaghan alanocallaghan commented Jan 7, 2025

Fairly minimal changes as the updated model spec tries to be transparent, but took the time to replace some deprecated calls.

Adds checks for our stated support (2D images with one input and output)

I was concerned about handling multiple inputs and outputs in BioimageIoTest , but I realise now that:

  • you can already have multiple inputs and outputs in 0.4 and we definitely don't handle those
  • we would have to completely refactor how classification is done to handle these anyway! (I think... maybe I underestimate the flexibility of DnnModel etc)

I've tested with the broad U-net model and the top 8 models on the model zoo. All of the 2 models work.

@alanocallaghan alanocallaghan changed the title Potentially implement 0.5 models Support 0.5 models Jan 10, 2025
@alanocallaghan
Copy link
Contributor Author

Should I be doing something to get the version catalog pointing to a snapshot release...?

@petebankhead
Copy link
Member

Usually no, but you may have to refresh your gradle dependencies if the snapshot was updated recently.
See https://docs.gradle.org/current/userguide/dependency_caching.html

(If it can’t be found at all, maybe we’re missing the snapshot maven repository… but I think it should be there ok)

@petebankhead
Copy link
Member

Not sure if it’s relevant but it’s been two weeks since we last updated the main QuPath snapshot jars (and therefore the catalog) - I’ve just started that action manually at https://github.com/qupath/qupath/actions/runs/13164711465

@alanocallaghan
Copy link
Contributor Author

Ahhh of course, yeah that'll be why it's not seeing the recent updates. Thanks!

@alanocallaghan alanocallaghan marked this pull request as ready for review February 7, 2025 09:03
@alanocallaghan
Copy link
Contributor Author

I would like to solve #10 but I can't identify how the bug occurs and it was an issue with the previous extension also, so am inclined to just merge this.

@alanocallaghan alanocallaghan merged commit d815852 into main Feb 12, 2025
1 check passed
@alanocallaghan alanocallaghan deleted the 0.5 branch February 12, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants