Merged
Conversation
Contributor
Author
|
The review request is more to make you aware and lodge objections/propose alternatives rather than request you to approve it |
Member
|
Thanks do you think we should be checking if these paths exist, and warning if not? |
Contributor
Author
|
Yes, I think that's best. In principle somebody could make the script before the conda env, but usually I'd guess it's a transcription error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary and sufficient for cuda to be detected for me on windows* and linux**
** I also uninstalled cuda on linux to test this