Skip to content

Add torch lib to path#30

Merged
alanocallaghan merged 1 commit intoqupath:mainfrom
alanocallaghan:add-torch-lib
Mar 21, 2025
Merged

Add torch lib to path#30
alanocallaghan merged 1 commit intoqupath:mainfrom
alanocallaghan:add-torch-lib

Conversation

@alanocallaghan
Copy link
Contributor

This is necessary and sufficient for cuda to be detected for me on windows* and linux**

  • Yes I actually tested this on windows 11
    ** I also uninstalled cuda on linux to test this

@alanocallaghan
Copy link
Contributor Author

The review request is more to make you aware and lodge objections/propose alternatives rather than request you to approve it

@alanocallaghan alanocallaghan merged commit 58cb91c into qupath:main Mar 21, 2025
1 check passed
@alanocallaghan alanocallaghan deleted the add-torch-lib branch March 21, 2025 09:35
@alanocallaghan alanocallaghan restored the add-torch-lib branch March 21, 2025 09:35
@petebankhead
Copy link
Member

Thanks do you think we should be checking if these paths exist, and warning if not?

@alanocallaghan
Copy link
Contributor Author

Yes, I think that's best. In principle somebody could make the script before the conda env, but usually I'd guess it's a transcription error

@alanocallaghan alanocallaghan deleted the add-torch-lib branch March 21, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants