Handle ctrl+letter weirdness on Linux #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Ctrl is held, the input display shows � for keypresses from the event text to uppercase. This uses the more conservative keycode name toUpper in the case when the key event is a letter. I'm sure this won't have unforeseen consequences.
Member
|
Thanks, makes sense but we’ll need to see how this behaves on all platforms - which have you tried? |
Contributor
Author
|
Only Linux so far, since they discontinued Win10 I don't have easy access to Win dev environment at home |
Member
|
This seems ok to me on Mac and Windows. I appended a couple of extra changes that hopefully haven't broken things. They changes attempt to handle:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Ctrl is held, the input display shows � for keypresses from the event text to uppercase. This uses the more conservative keycode name toUpper in the case when the key event is a letter. I'm sure this won't have unforeseen consequences.
Related to comments in qupath/qupath#2033