Draft
Conversation
* [QF-3542] Daily ayah pushed down o be above the community section and under explore topics (#2540) * Daily ayah pushed down o be above the community section and under explore topics. Add 'quran-in-year-verse-title' translations for multiple languages and enhance TranslationText component to display chapter references. Introduce useChapter hook for fetching chapter data. * Refactor TranslationText and VerseAndTranslation components for improved data handling and UI. Update useChapter hook to include loading state and enhance error handling. Adjust styles in VerseText module for better presentation. * Add shouldShowTitle prop to PlainVerseText component and conditionally render title * Enhance TranslationText component with Next.js Link for chapter references, improve error handling in VerseAndTranslation by using optional chaining, and update SCSS comments for clarity. Add JSDoc documentation to useChapter hook for better understanding of its functionality. * Refactor VerseAndTranslation component to improve error handling and add detailed JSDoc documentation. Enhance useChapter hook with loading state and revalidation capabilities. Update verse reference handling to use getVerseUrl for improved URL generation. * Update TranslationText component to use HTML entities for quotes, simplify mutate function in VerseAndTranslation, and enhance useChapter hook with TypeScript typing for mutate function. * Refactor TranslationText and VerseAndTranslation components to utilize getVerseUrl for chapter references, enhancing URL generation consistency. Remove redundant import of getVerseUrl in VerseAndTranslation. * Enhance TranslationText component to conditionally render text with click handling when chapter name and reference are not available, improving user interaction and display logic. * Remove 'quran-in-year-verse-title' translations from multiple language JSON files and enhance QuranInYearSection component to conditionally display title and reference, improving user experience and consistency across translations. * Refactor TranslationAndReference component to improve accessibility by separating click handling from the main div, enhancing user interaction while maintaining existing functionality. * Refactor TranslationAndReference by updating click handling logic and enhancing aria-label attributes for better screen reader support. * Refactor QuranInYearSection to use localized title text and introduce FootnoteAndSubFootnote component for improved footnote handling * Fix direction in the TranslationAndReference * Update surah name, chapter and verse number to use english * Use chaptersData from static props --------- Co-authored-by: Osama Sayed <toto777_90@hotmail.com> * Sync locales --------- Co-authored-by: afifvdin <afifudin.fdn@gmail.com>
* [QF-3542] Daily ayah pushed down o be above the community section and under explore topics (#2540) * Daily ayah pushed down o be above the community section and under explore topics. Add 'quran-in-year-verse-title' translations for multiple languages and enhance TranslationText component to display chapter references. Introduce useChapter hook for fetching chapter data. * Refactor TranslationText and VerseAndTranslation components for improved data handling and UI. Update useChapter hook to include loading state and enhance error handling. Adjust styles in VerseText module for better presentation. * Add shouldShowTitle prop to PlainVerseText component and conditionally render title * Enhance TranslationText component with Next.js Link for chapter references, improve error handling in VerseAndTranslation by using optional chaining, and update SCSS comments for clarity. Add JSDoc documentation to useChapter hook for better understanding of its functionality. * Refactor VerseAndTranslation component to improve error handling and add detailed JSDoc documentation. Enhance useChapter hook with loading state and revalidation capabilities. Update verse reference handling to use getVerseUrl for improved URL generation. * Update TranslationText component to use HTML entities for quotes, simplify mutate function in VerseAndTranslation, and enhance useChapter hook with TypeScript typing for mutate function. * Refactor TranslationText and VerseAndTranslation components to utilize getVerseUrl for chapter references, enhancing URL generation consistency. Remove redundant import of getVerseUrl in VerseAndTranslation. * Enhance TranslationText component to conditionally render text with click handling when chapter name and reference are not available, improving user interaction and display logic. * Remove 'quran-in-year-verse-title' translations from multiple language JSON files and enhance QuranInYearSection component to conditionally display title and reference, improving user experience and consistency across translations. * Refactor TranslationAndReference component to improve accessibility by separating click handling from the main div, enhancing user interaction while maintaining existing functionality. * Refactor TranslationAndReference by updating click handling logic and enhancing aria-label attributes for better screen reader support. * Refactor QuranInYearSection to use localized title text and introduce FootnoteAndSubFootnote component for improved footnote handling * Fix direction in the TranslationAndReference * Update surah name, chapter and verse number to use english * Use chaptersData from static props --------- Co-authored-by: Osama Sayed <toto777_90@hotmail.com> * Sync locales --------- Co-authored-by: afifvdin <afifudin.fdn@gmail.com>
* [QF-3542] Daily ayah pushed down o be above the community section and under explore topics (#2540) * Daily ayah pushed down o be above the community section and under explore topics. Add 'quran-in-year-verse-title' translations for multiple languages and enhance TranslationText component to display chapter references. Introduce useChapter hook for fetching chapter data. * Refactor TranslationText and VerseAndTranslation components for improved data handling and UI. Update useChapter hook to include loading state and enhance error handling. Adjust styles in VerseText module for better presentation. * Add shouldShowTitle prop to PlainVerseText component and conditionally render title * Enhance TranslationText component with Next.js Link for chapter references, improve error handling in VerseAndTranslation by using optional chaining, and update SCSS comments for clarity. Add JSDoc documentation to useChapter hook for better understanding of its functionality. * Refactor VerseAndTranslation component to improve error handling and add detailed JSDoc documentation. Enhance useChapter hook with loading state and revalidation capabilities. Update verse reference handling to use getVerseUrl for improved URL generation. * Update TranslationText component to use HTML entities for quotes, simplify mutate function in VerseAndTranslation, and enhance useChapter hook with TypeScript typing for mutate function. * Refactor TranslationText and VerseAndTranslation components to utilize getVerseUrl for chapter references, enhancing URL generation consistency. Remove redundant import of getVerseUrl in VerseAndTranslation. * Enhance TranslationText component to conditionally render text with click handling when chapter name and reference are not available, improving user interaction and display logic. * Remove 'quran-in-year-verse-title' translations from multiple language JSON files and enhance QuranInYearSection component to conditionally display title and reference, improving user experience and consistency across translations. * Refactor TranslationAndReference component to improve accessibility by separating click handling from the main div, enhancing user interaction while maintaining existing functionality. * Refactor TranslationAndReference by updating click handling logic and enhancing aria-label attributes for better screen reader support. * Refactor QuranInYearSection to use localized title text and introduce FootnoteAndSubFootnote component for improved footnote handling * Fix direction in the TranslationAndReference * Update surah name, chapter and verse number to use english * Use chaptersData from static props --------- Co-authored-by: Osama Sayed <toto777_90@hotmail.com> * Sync locales --------- Co-authored-by: afifvdin <afifudin.fdn@gmail.com>
* Fix: QF-3500 Sharing search query (replaced canonical path) * applied codderrabbit suggestions * applied copilot suggestion * Address comments --------- Co-authored-by: Osama Sayed <toto777_90@hotmail.com>
* Adding right padding to the title text of a modal to prevent the title from overlapping with the close cross * Ensure that the cross no longer touches the separator bar. * changed vw to px * applied copilot suggestions * center vertically the close cross
changed isOpen to true by default
changed isOpen to true by default
changed isOpen to true by default
* Changed the style of the learning plans on the homepage to show only the image * fixed rtl view for "enrolled" badge * fixed rtl view for "enrolled" badge * applied copilot suggestions * added 'new' pill based on the 'enrolled' pill * added completed pill
* updated card size on mobile * fixeda size
* QF-4026 - Change the LP view on the homepage (#2616) * Changed the style of the learning plans on the homepage to show only the image * fixed rtl view for "enrolled" badge * fixed rtl view for "enrolled" badge * applied copilot suggestions * added 'new' pill based on the 'enrolled' pill * added completed pill * Updated LP Card size on mobile (#2621) * updated card size on mobile * fixeda size * Qf 3200 explore topics section scrollable horizontally (#2528) * feat: ensure horizontal scrolling in ExploreTopicsSection * test: add Playwright test for horizontal scroll in ExploreTopicsSection * fix: improve error handling and RTL clarity in scroll test - Add explicit error handling for missing scrollable container - Rename scrollRightAndWait to scrollByAndWait for RTL clarity - Add JSDoc explaining RTL behavior and fallback strategy * refactor: improve scroll test helper and fix CSS formatting - Consolidate RTL fallback logic in scrollByAndWait helper - Encapsulate forward/reverse scroll attempts with identical polling - Simplify test to single scrollByAndWait call - Fix scrollbar CSS formatting inconsistencies - Remove deprecated -webkit-overflow-scrolling property --------- Co-authored-by: Rayane Staszewski <56195432+zonetecde@users.noreply.github.com> Co-authored-by: Yousef Dergham <79238462+yousefdergham@users.noreply.github.com>
#2541) Enhance ExploreTopicsSection styling for better layout and scrolling behavior
* Changed the style of the learning plans on the homepage to show only the image * fixed rtl view for "enrolled" badge * fixed rtl view for "enrolled" badge * applied copilot suggestions * added 'new' pill based on the 'enrolled' pill * added completed pill
* updated card size on mobile * fixeda size
… in responsive view (#2622) * changed order of the sections on homepage for guest user in responsive view * changed a logic
…ranslation list (#2594) * Add shortDescription field to AvailableTranslation interface * Update ShortDescription interface to allow nullable fields for description and languageName * Add HoverablePopover component to display translation short descriptions with tooltips - Integrated HoverablePopover in TranslationSelectionBody to show short descriptions for translations. - Updated Popover and Tooltip components to support new INFO type for better styling. - Enhanced Tooltip and Popover to conditionally apply styles based on the type prop. * Enhance styling for Popover, Tooltip, and SearchSelectionBody components - Added new .info class to Popover and Tooltip for consistent elevated background styling. - Introduced .containerInfo class to Popover for margin adjustments. - Updated SearchSelectionBody with .infoIcon class for improved icon styling and layout adjustments. * Add information-circle-outline icon and update imports in TranslationSelectionBody - Introduced a new SVG icon for information-circle-outline. - Updated the import path for the info icon in TranslationSelectionBody to use the new SVG. - Removed unused imports in TranslationSelectionBody for cleaner code. * Refactor imports and enhance Tooltip styling - Reintroduced necessary imports in TranslationSelectionBody for improved functionality. - Cleaned up Popover and Tooltip styles by removing unnecessary whitespace. - Enhanced the .info class in Tooltip with additional styling properties for better presentation. * Enhance Popover styling with additional properties - Added z-index, padding, font-size, line-height, and max-width to improve Popover appearance. - Ensured consistent styling for better integration with other components. * Refactor Popover and HoverablePopover components to use tooltipType prop - Updated Popover and HoverablePopover components to replace the type prop with tooltipType for better clarity and consistency. - Adjusted the TranslationSelectionBody to utilize the new tooltipType prop for the HoverablePopover. - Enhanced accessibility by adding aria-label to the info icon in TranslationSelectionBody. * Add translation-info key to common.json for Arabic and English locales - Introduced a new key translation-info in both Arabic and English locale files to provide users with information about translations. - Updated the sidebar navigation close message to maintain consistency in both language files. * Refactor Popover and Tooltip styles to utilize infoTooltipStyles mixin - Updated the .info class in both Popover and Tooltip components to use the new infoTooltipStyles mixin for consistent styling. - Removed redundant properties from the .info class to streamline the code and enhance maintainability. * Update ShortDescription interface to remove nullability from description and languageName fields * Fix spacing in Popover styles for better readability - Adjusted the SCSS selector for the span element within the Popover component to improve code clarity and maintainability. * Update tooltip styles to use a new shadow variable - Replaced the hardcoded box-shadow in the infoTooltipStyles mixin with a new CSS variable for tooltip shadow. - Added the --shadow-tooltip variable to dark, light, and sepia themes for consistent shadow styling across themes.
* Update QDC banner for Goals * use login hook and change background color of banner * [QF-3553] restore data test id * [QF-3553] styling * [QF-3553] configure icon color for cta * [QF-3553] fix banner cta styles * [QF-3553] update parameters for Banner * [QF-3553] add aria-hidden * [QF-3553] fix error * [QF-3553] add test * [QF-3553] fix layout and put back testid * [QF-3553] add log * [QF-3553] refactor * [QF-3553] remove unused * [QF-3553] remove duplicate * [QF-3553] extract flex to mixin * [QF-3553] update race condition and css * [QF-3553] remove mixin * [QF-3553] update streak api mocks
* Update navbar and navigation drawer with new icons, language selection, and theme switcher * Refactor ProfileAvatarButton to correctly dispatch navigation drawer state and update SCSS for theme switcher SVG transitions * Refactor Navbar and AppContent components. Update SCSS for backdrop and transitions * Refactor AppContent and Navbar components. Update LanguageContainer for accessibility and improve project links handling in OurProjectsCollapsible. * Enhance accessibility in AppContent and LanguageContainer components. Update aria attributes and improve project link handling in OurProjectsCollapsible. Adjust SCSS for better viewport handling and transition effects. * Replace relative unit with absolute unit, fundraising title, extract link and remove unnecessary code * Restore onSuffixClicked in Collapsible * Add shouldSuffixTrigger prop in Collapsible * fix * Remove quternary from IconColor, rollback link, unused tags, and refactor url * Remove unnecessary breakpoints and refactor menu * [QF-3593] fix collapsible and language container module * [QF-3593] invert condition in more menu collapsible * [QF-3593] remove unused * [QF-3593] refactor * [QF-3593] add missing aria current * [QF-3593] remove unused, refactor and maintain logic consistency * [QF-3593] add focus management issue and accessibility in collapsible * [QF-3593] add guard at shouldShowOpen in collapsible * [QF-3593] fixing test * [QF-3593] fix collapsible and test * [QF-3593] fix language container dispatcher, donor page load test and drawer id * [QF-3593] refactor * [QF-3593] refactor button component for ref * [QF-3593] refactor collapsible and scss * [QF-3593] add spacing-hairline-px * [QF-3593] Fix profile avatar button * [QF-3593] fix theme, icons, dropdown * [QF-3593] clean merge
…ponsivene and RTL support (#2558) * Update PopularButton and ChapterCard styles for improved responsiveness and RTL support * Update HeroButtons styles to enforce nowrap text wrapping for better layout consistency * Update PopularButton styles to set fixed widths for improved layout on different screen sizes * Remove extra newline in PopularButton styles * Remove unnecessary whitespace in PopularButton styles for cleaner code * Implement PopularDropdown component and integrate it into HomePageHero; refactor PopularButton to accept onClick prop for dropdown handling * Remove PopularButton styles as part of the component refactor; streamline codebase by eliminating unused SCSS file.
* Refactor Navbar and ContextMenu to integrate SettingsButton and SettingsDrawer - Removed SettingsDrawer from NavbarBody and added SettingsButton to ContextMenu for better accessibility. - Introduced a new SettingsButton component to handle opening the SettingsDrawer. - Updated ContextMenu layout to accommodate the new SettingsButton while maintaining responsiveness. * Update ContextMenu styles for improved layout and responsiveness - Adjusted padding values for better alignment in the ContextMenu. - Added new styles for reading preferences and chapter navigation components. - Enhanced responsiveness for chapter navigation and settings display on mobile devices. * Add event logging and integration tests for SettingsButton functionality - Integrated event logging to track when the settings drawer is opened. - Created integration tests to verify the visibility and functionality of the settings drawer on both desktop and mobile views. * Update ContextMenu to clarify SettingsDrawer rendering - Changed comment to specify that the SettingsDrawer component is being rendered in the ContextMenu. * Refactor ContextMenu and SettingsButton for improved performance and clarity * Fix logic in ContextMenu for mobile view handling and update SettingsButton props interface * Update ContextMenu styles for improved responsiveness and layout adjustments * Add SettingsDrawer to NavbarBody and remove from ContextMenu for improved structure
* Update popup tab design for reflections * Remove header text from Reflection modal in BottomActionsModals component * Show ayah conditionally on the page only but no popup * Refactor ReflectionBodyContainer: Simplify icon usage, enhance reflection view logging, and clean up styles. Remove unnecessary TypeScript ignore comment and adjust tab item selection logic. * Remove unnecessary useCallback
fix(notes): remove 3rd bullet from access-anywhere section
* feat(pages): add Arabic version of What is Ramadan page Introduce Arabic localization for the What is Ramadan page, including a new React component (WhatIsRamadanArabic.tsx) and corresponding SCSS styles. Update the main index.tsx to conditionally render the Arabic content based on language selection. Also, enhance contentPage.module.scss to style the strong tag alongside b for better text formatting. * feat(pages): add Arabic version of About the Quran page - Add AboutTheQuranArabic component with Arabic content - Update index.tsx to conditionally render Arabic version based on language - Modify styles for better Arabic support in both About the Quran and What is Ramadan pages - Include call-to-action button in Arabic Ramadan page for consistency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This reverts commit 0b5a9c0.
…iterations smaller
yousefdergham
force-pushed
the
testing
branch
from
9c8660c to
b9c054d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.