fix: correct audioPlayerState spreading in migration 18#3091
Open
haroon0x wants to merge 1 commit intoquran:productionfrom
Open
fix: correct audioPlayerState spreading in migration 18#3091haroon0x wants to merge 1 commit intoquran:productionfrom
haroon0x wants to merge 1 commit intoquran:productionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration 18 in
src/redux/migrations.tscontains a copy-paste bug. It spreadsstate.readingPreferencesintoaudioPlayerState, which completely overwrites the audio player state with unrelated reading preferences data.Closes: #3088
Current Behavior
Changed
Impact
Any user whose Redux state was migrated through version 18 will have a corrupted
audioPlayerState, with all audio player settings overwritten by reading preferences data. This can cause broken audio playback, incorrect reciter selection, and unexpected UI state.Type of Change
expected)
If Breaking Change
Scope Confirmation
Environment Variables
EXAMPLE_VARRollback Safety
Test Plan
Testing steps:
Edge Cases Verified
Pre-Review Checklist
Code Quality
anytypes used (or justified if unavoidable)Testing & Validation
yarn test)yarn lint)yarn build)Documentation
Localization (if UI changes)
next-translateAccessibility (if UI changes)
Screenshots/Videos
Related PRs
Reviewer Notes
AI Assistance Disclosure