Skip to content

refactor: replace hardcoded learning plan flashcard and quiz styles with CSS vars#3145

Open
ahmedosamasawah wants to merge 1 commit intoquran:productionfrom
ahmedosamasawah:refactor/lp-flashcard-quiz-css-vars
Open

refactor: replace hardcoded learning plan flashcard and quiz styles with CSS vars#3145
ahmedosamasawah wants to merge 1 commit intoquran:productionfrom
ahmedosamasawah:refactor/lp-flashcard-quiz-css-vars

Conversation

@ahmedosamasawah
Copy link
Contributor

Summary

This PR replaces hardcoded style values with CSS variables in the Learning Plan flashcard and quiz UI to match the repo’s styling conventions.

What Changed

  • Updated SCSS in:
    • src/components/Course/FlashCards/FlashCardCarousel/FlashCardCarousel.module.scss
    • src/components/Course/FlashCards/FlashCardDeck/FlashCardDeck.module.scss
    • src/components/Course/FlashCards/FlashCardList/FlashCardList.module.scss
    • src/components/Course/FlashCards/_shared.scss
    • src/components/Course/LessonHtmlContent/LessonHtmlContent.module.scss
    • src/components/Course/LessonQuiz/LessonQuiz.module.scss
  • Replaced direct literals (font sizes, spacing, borders, transitions, opacity, shadows) with:
    • existing global design tokens where available
    • scoped component-level CSS custom properties where values are component-specific
  • Extended the shared flashcard mixin to accept variable-driven timing/line-height/opacity values.
  • Removed redundant pass-through vars in the carousel for a simpler setup.

Notes

  • No behavior or logic changes; styling consistency cleanup only.

@mustafa0x
Copy link
Contributor

@codex review this change, and see whether it can be simplified

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants