Skip to content

fix: internationalize learning plan flashcard widget text for all locales#3146

Open
ahmedosamasawah wants to merge 6 commits intoquran:productionfrom
ahmedosamasawah:fix/learning-plan-widget-i18n-all-locales
Open

fix: internationalize learning plan flashcard widget text for all locales#3146
ahmedosamasawah wants to merge 6 commits intoquran:productionfrom
ahmedosamasawah:fix/learning-plan-widget-i18n-all-locales

Conversation

@ahmedosamasawah
Copy link
Contributor

@ahmedosamasawah ahmedosamasawah commented Feb 17, 2026

Summary

Internationalized learning-plan flashcard widget copy using learn translation keys from learn.json, kept non-English locale files untouched (Lokalise-managed), removed in-code default fallbacks and unnecessary translation mocks, and preserved interactive widget rendering with verse-widget parsing behavior intact.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 730f01e475

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mustafa0x
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b7253e170

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mustafa0x
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fa8f76215

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


render(<FlashCardDeck cards={cards} onComplete={onComplete} />);
fireEvent.click(screen.getByRole('button', { name: 'Mark as known' }));
fireEvent.click(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe test id needs to be added then click on it using test id instead of labels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants