Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Jan 13, 2025

Checklist

Thank you for contributing to HierarchicalEOM.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title

Related issues or PRs

This PR is currently waiting the following PR to be merged, and QuantumToolbox v0.25.0 to be released:
qutip/QuantumToolbox.jl#360

@ytdHuang ytdHuang marked this pull request as ready for review January 20, 2025 05:41
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (67438bc) to head (299d471).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/heom_matrices/heom_matrix_base.jl 86.36% 3 Missing ⚠️
src/bath/BosonBath.jl 85.71% 1 Missing ⚠️
src/bath/FermionBath.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   91.70%   91.92%   +0.21%     
==========================================
  Files          24       24              
  Lines        1483     1498      +15     
==========================================
+ Hits         1360     1377      +17     
+ Misses        123      121       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang merged commit bf04bdc into main Jan 20, 2025
17 of 19 checks passed
@ytdHuang ytdHuang deleted the dev/dimensions branch January 20, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants