Skip to content

Update QuantumToolbox dependency and refactor ODE solver options usage #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TendonFFF wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update QuantumToolbox dependency and refactor ODE solver options usage #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ OrdinaryDiffEqCore = "1, 2, 3"
OrdinaryDiffEqLowOrderRK = "1"
Pkg = "1"
ProgressMeter = "1.11.0"
QuantumToolbox = "0.40 - 0.42"
QuantumToolbox = "0.43"
Reexport = "1"
SciMLBase = "2.105"
SciMLOperators = "1.11"
Expand Down
2 changes: 1 addition & 1 deletion src/HierarchicalEOM.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import QuantumToolbox:
getVal,
TimeEvolutionProblem,
AbstractSaveFunc,
DEFAULT_ODE_SOLVER_OPTIONS,
default_ode_solver_options,
SteadyStateODECondition

# SciML packages (for OrdinaryDiffEq and LinearSolve)
Expand Down
2 changes: 1 addition & 1 deletion src/evolution.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function HEOMsolveProblem(

# define ODE problem (L should be an AbstractSciMLOperator)
L = get_cached_HEOMLS_data(_make_L(M, H_t), u0)
kwargs2 = _merge_saveat(tlist, e_ops, DEFAULT_ODE_SOLVER_OPTIONS; kwargs...)
kwargs2 = _merge_saveat(tlist, e_ops, default_ode_solver_options(eltype(M)); kwargs...)
kwargs3 = _merge_tstops(kwargs2, isconstant(L), tlist)
kwargs4 = _generate_heom_kwargs(e_ops, makeVal(progress_bar), tlist, kwargs3, SaveFuncHEOMSolve, M)
prob = ODEProblem{getVal(inplace), FullSpecialize}(L, u0, tspan, params; kwargs4...)
Expand Down
4 changes: 2 additions & 2 deletions src/steadystate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ function QuantumToolbox.steadystate(

kwargs2 = merge(
(
abstol = DEFAULT_ODE_SOLVER_OPTIONS.abstol,
reltol = DEFAULT_ODE_SOLVER_OPTIONS.reltol,
abstol = default_ode_solver_options(eltype(M)).abstol,
reltol = default_ode_solver_options(eltype(M)).reltol,
Comment on lines 96 to +98
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default_ode_solver_options(eltype(M)) is called twice just to access abstol/reltol. Consider calling it once (e.g., bind to a local opts) and then reading both fields to avoid duplicate work and guarantee both values come from the same options instance.

Copilot uses AI. Check for mistakes.
save_everystep = false,
saveat = ftype[],
),
Expand Down
Loading