Fix type conversion of tlist in time evolution
#229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 94.74% 93.24% -1.51%
==========================================
Files 30 30
Lines 2151 2175 +24
==========================================
- Hits 2038 2028 -10
- Misses 113 147 +34 ☔ View full report in Codecov by Sentry. |
albertomercurio
approved these changes
Sep 19, 2024
| QuantumObject(SparseMatrixCSC{T}(A.data), A.type, A.dims) | ||
|
|
||
| # functions for getting Float or Complex element type | ||
| _FType(::QuantumObject{<:AbstractArray{T}}) where {T<:Number} = _FType(T) |
Member
There was a problem hiding this comment.
I think it is better to put them together with the othe definitions in the utilities file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GPU calculations, the arrays might be specified with 32-bit element type.
The current conversion of
tlistalways converts toFloat64, which might cause extra memory allocation or potential errors (for supporting different GPU platforms) in the future development.