Skip to content

Fix return type of rand_unitary #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix return type of rand_unitary #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/qobj/operators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
# Because inv(Λ) ⋅ R has real and strictly positive elements, Q · Λ is therefore Haar distributed.
Λ = diag(R) # take the diagonal elements of R
Λ ./= abs.(Λ) # rescaling the elements
return QuantumObject(dense_to_sparse(Q * Diagonal(Λ)); type = Operator, dims = dimensions)
return QuantumObject(sparse_to_dense(Q * Diagonal(Λ)); type = Operator, dims = dimensions)

Check warning on line 51 in src/qobj/operators.jl

View check run for this annotation

Codecov / codecov/patch

src/qobj/operators.jl#L51 

Added line #L51 was not covered by tests
end
function rand_unitary(dimensions::Union{AbstractVector{Int},Tuple}, ::Val{:exp})
N = prod(dimensions)
Expand All @@ -59,7 +59,7 @@
# generate Hermitian matrix
H = QuantumObject((Z + Z') / 2; type = Operator, dims = dimensions)

return exp(-1.0im * H)
return sparse_to_dense(exp(-1.0im * H))

Check warning on line 62 in src/qobj/operators.jl

View check run for this annotation

Codecov / codecov/patch

src/qobj/operators.jl#L62 

Added line #L62 was not covered by tests
end
rand_unitary(dimensions::Union{AbstractVector{Int},Tuple}, ::Val{T}) where {T} =
throw(ArgumentError("Invalid distribution: $(T)"))
Expand Down