Make clenshaw method as default for wigner #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 94.53% 93.97% -0.56%
==========================================
Files 32 32
Lines 2434 2424 -10
==========================================
- Hits 2301 2278 -23
- Misses 133 146 +13 ☔ View full report in Codecov by Sentry. |
ytdHuang
reviewed
Oct 31, 2024
ytdHuang
reviewed
Oct 31, 2024
ytdHuang
approved these changes
Oct 31, 2024
albertomercurio
added a commit
to albertomercurio/QuantumToolbox.jl
that referenced
this pull request
Nov 10, 2024
* Make clenshaw method as default for wigner * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here I make the
WignerClenshawas default method for thewignerfunction, just like in qutip. Moreover, I changed the keyword argument name fromsolvertomethod, just as qutip. Finally, I improved the docstring.