A lazy method to construct QobjEvo
#282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytdHuang
commented
Nov 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 94.16% 93.62% -0.54%
==========================================
Files 32 32
Lines 2468 2463 -5
==========================================
- Hits 2324 2306 -18
- Misses 144 157 +13 ☔ View full report in Codecov by Sentry. |
albertomercurio
approved these changes
Nov 2, 2024
albertomercurio
pushed a commit
to albertomercurio/QuantumToolbox.jl
that referenced
this pull request
Nov 10, 2024
* add a lazy method to construct `QobjEvo` * format files * improve tests to make sure time-independent problems are `MatrixOperator` * modify docstrings * fix typo * fix extra `ScalarOperator` in `mcsolve` * rebase to `ScaledOperator` in time-independent `mcsolve` * add missing import in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by runningmake docs.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Summary of this PR:
QobjEvomakeThis breaks many things in dynamical solversmcsolveProblemacceptH_eff::AbstractQuantumObjectto fix extraScalarOperatorfor time-independentmcsolve.MatrixOperatorRelated issues or PRs
Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]
close #281