Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Nov 14, 2024

Description

I don't know why the favicon sometimes show up, sometimes disappeared

I just upload a favicon.ico file into the root directory in gh-pages, and add an extra link for it in config.mts.

@ytdHuang ytdHuang added the Skip ChangeLog Skip changelog update check in PR label Nov 14, 2024
@albertomercurio
Copy link
Member

But what if we use the assets kwarg in the public API instead of modifying the raw code anytime?

@albertomercurio albertomercurio merged commit 9567c45 into main Nov 15, 2024
5 checks passed
@ytdHuang ytdHuang deleted the ytdHuang-patch-2 branch November 15, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip ChangeLog Skip changelog update check in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants