-
Notifications
You must be signed in to change notification settings - Fork 31
Add Benchmark Comparison #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| *.jl.cov | ||
| *.jl.mem | ||
| Manifest.toml | ||
| /Manifest.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need to be rebased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I need it to keep the Manifest of the benchmark comparison, otherwise it removes every Manifest file. I need the Manifest because I want reproducibility, like also the requirements.txt for the python packages.
| @@ -0,0 +1 @@ | |||
| /Manifest.toml | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be tracked by git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is executed only locally, to have the best performances in the comparison. So it would be just a static file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will change only when we re-run the benchmarks comparison locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be tracked by git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sa me as above
|
The figure should not be tracked by git, cause it keeps updating everytime the script is executed. |
Description
As title, I added a benchmark comparison between QuantumToolbox.jl, QuTiP, dynamiqs, and QuantumOptics.jl. I made a script file which makes everything reproducible. I added the plot on both the Documentation and the README.