Skip to content

Conversation

@albertomercurio
Copy link
Member

Description

As title, I added a benchmark comparison between QuantumToolbox.jl, QuTiP, dynamiqs, and QuantumOptics.jl. I made a script file which makes everything reproducible. I added the plot on both the Documentation and the README.

@albertomercurio albertomercurio added the Skip ChangeLog Skip changelog update check in PR label Nov 19, 2024
*.jl.cov
*.jl.mem
Manifest.toml
/Manifest.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this need to be rebased.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I need it to keep the Manifest of the benchmark comparison, otherwise it removes every Manifest file. I need the Manifest because I want reproducibility, like also the requirements.txt for the python packages.

@@ -0,0 +1 @@
/Manifest.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be tracked by git

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is executed only locally, to have the best performances in the comparison. So it would be just a static file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will change only when we re-run the benchmarks comparison locally.

Copy link
Member

@ytdHuang ytdHuang Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be tracked by git

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sa me as above

@ytdHuang
Copy link
Member

The figure should not be tracked by git, cause it keeps updating everytime the script is executed.
So, I suggest we don't put the figure in README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip ChangeLog Skip changelog update check in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants